Details

Reviewers

jdoerfert
sstefan1

Summary

Applies performance-noexcept-move-constructor to llvm core. One would think that this check does not matter since we do not allow exceptions due to the LLVM styleguide. However, STL containers (including std::variant and std::optional) do check the noexcept tag to see if it's safe to move. Therefore, we should make all these classes as safe to move so these STL containers can be as efficient as possible.

Diff Detail

Unit TestsFailed
View All

	Time	Test
	60,190 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded::vloxseg.c Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/16/include -nostdsysteminc -triple riscv64 -target-feature +v -target-feature +zfh -target-feature +experimental-zvfh -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vloxseg.c -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -passes=mem2reg \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vloxseg.c
	60,280 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded::vluxseg.c Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/16/include -nostdsysteminc -triple riscv64 -target-feature +v -target-feature +zfh -target-feature +experimental-zvfh -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vluxseg.c -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -passes=mem2reg \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vluxseg.c
	60,170 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded::vloxseg.c Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/16/include -nostdsysteminc -triple riscv64 -target-feature +v -target-feature +zfh -target-feature +experimental-zvfh -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded/vloxseg.c -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -passes=mem2reg \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded/vloxseg.c
	60,330 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded::vluxseg.c Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/16/include -nostdsysteminc -triple riscv64 -target-feature +v -target-feature +zfh -target-feature +experimental-zvfh -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded/vluxseg.c -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -passes=mem2reg \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded/vluxseg.c
	60,040 ms	x64 debian > MLIR.Examples/standalone::test.toy Script: -- : 'RUN: at line 1'; /usr/bin/cmake /var/lib/buildkite-agent/builds/llvm-project/mlir/examples/standalone -G "Ninja" -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DCMAKE_C_COMPILER=/usr/bin/clang -DLLVM_ENABLE_LIBCXX=OFF -DMLIR_DIR=/var/lib/buildkite-agent/builds/llvm-project/build/lib/cmake/mlir -DLLVM_USE_LINKER=lld -DPython3_EXECUTABLE="/usr/bin/python3.9"
		View Full Test Results (7 Failed)

Event Timeline

Skylion007 created this revision.Jan 16 2023, 11:01 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2023, 11:01 AM

Herald added subscribers: kmitropoulou, jeroen.dobbelaere, ormris and 5 others. · View Herald Transcript

Skylion007 requested review of this revision.Jan 16 2023, 11:01 AM

Herald added a reviewer: jdoerfert. · View Herald TranscriptJan 16 2023, 11:01 AM

Herald added a reviewer: sstefan1. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B208089: Diff 489605.Jan 16 2023, 11:09 AM

Made sure headers updated too. Skip support and ADT files for now.

Harbormaster completed remote builds in B208094: Diff 489613.Jan 16 2023, 11:57 AM

Fixed forward declare bug

Fix forward declare typo

Harbormaster completed remote builds in B208101: Diff 489623.Jan 16 2023, 12:28 PM

Fix another forward declare

bmahjour removed a subscriber: bmahjour.Jan 16 2023, 12:44 PM

Harbormaster completed remote builds in B208102: Diff 489624.Jan 16 2023, 12:48 PM

Make jitlink cpp match

Harbormaster completed remote builds in B208104: Diff 489629.Jan 16 2023, 1:15 PM

Fixup one another cpp error

revert changes to JITLink

Harbormaster completed remote builds in B208109: Diff 489634.Jan 16 2023, 3:04 PM

[llvm][NFC] Apply performance-noexcept-move-constructor to llvm coreNeeds ReviewPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Revision ContentsChangeset List

Diff 489634

llvm/include/llvm/Analysis/AliasAnalysis.h

llvm/include/llvm/Analysis/BasicAliasAnalysis.h

llvm/include/llvm/Analysis/BlockFrequencyInfo.h

llvm/include/llvm/Analysis/BranchProbabilityInfo.h

llvm/include/llvm/Analysis/CGSCCPassManager.h

llvm/include/llvm/Analysis/CallGraph.h

llvm/include/llvm/Analysis/DDG.h

llvm/include/llvm/Analysis/GlobalsModRef.h

llvm/include/llvm/Analysis/InlineSizeEstimatorAnalysis.h

llvm/include/llvm/Analysis/LazyCallGraph.h

llvm/include/llvm/Analysis/LazyValueInfo.h

llvm/include/llvm/Analysis/LoopAnalysisManager.h

llvm/include/llvm/Analysis/LoopInfo.h

llvm/include/llvm/Analysis/MustExecute.h

llvm/include/llvm/Analysis/ObjCARCAliasAnalysis.h

llvm/include/llvm/Analysis/OptimizationRemarkEmitter.h

llvm/include/llvm/Analysis/ScalarEvolution.h

llvm/include/llvm/Analysis/ScalarEvolutionAliasAnalysis.h

llvm/include/llvm/Analysis/TargetLibraryInfo.h

llvm/include/llvm/Analysis/TargetTransformInfo.h

llvm/include/llvm/Analysis/TargetTransformInfoImpl.h

llvm/include/llvm/CodeGen/MachineModuleInfo.h

llvm/include/llvm/DebugInfo/PDB/PDBSymbol.h

llvm/include/llvm/Demangle/Demangle.h

llvm/include/llvm/Demangle/ItaniumDemangle.h

llvm/include/llvm/ExecutionEngine/JITSymbol.h

llvm/include/llvm/ExecutionEngine/Orc/Core.h

llvm/include/llvm/ExecutionEngine/Orc/Shared/WrapperFunctionUtils.h

llvm/include/llvm/ExecutionEngine/Orc/SymbolStringPool.h

llvm/include/llvm/ExecutionEngine/Orc/ThreadSafeModule.h

llvm/include/llvm/IR/Comdat.h

llvm/include/llvm/IR/Metadata.h

llvm/include/llvm/IR/PassManager.h

llvm/include/llvm/IR/PassManagerImpl.h

llvm/include/llvm/IR/PassManagerInternal.h

llvm/include/llvm/IR/TrackingMDRef.h

llvm/include/llvm/InterfaceStub/IFSStub.h

llvm/include/llvm/Object/Archive.h

llvm/include/llvm/Object/Binary.h

llvm/include/llvm/Object/ELFObjectFile.h

llvm/lib/Analysis/AliasAnalysis.cpp

llvm/lib/Analysis/BlockFrequencyInfo.cpp

llvm/lib/Analysis/CallGraph.cpp

llvm/lib/Analysis/DDG.cpp

llvm/lib/Analysis/GlobalsModRef.cpp

llvm/lib/Analysis/InlineSizeEstimatorAnalysis.cpp

llvm/lib/Analysis/LazyCallGraph.cpp

llvm/lib/Analysis/ScalarEvolution.cpp

llvm/lib/Analysis/TargetLibraryInfo.cpp

llvm/lib/Analysis/TargetTransformInfo.cpp

llvm/lib/Bitcode/Reader/MetadataLoader.h

llvm/lib/Bitcode/Reader/MetadataLoader.cpp

llvm/lib/CodeGen/MachineModuleInfo.cpp

llvm/lib/DebugInfo/PDB/PDBSymbol.cpp

llvm/lib/Demangle/ItaniumDemangle.cpp

llvm/lib/ExecutionEngine/Orc/Core.cpp

llvm/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp

llvm/lib/IR/Comdat.cpp

llvm/lib/InterfaceStub/ELFObjHandler.cpp

llvm/lib/InterfaceStub/IFSStub.cpp

llvm/lib/MC/MCParser/MasmParser.cpp

llvm/lib/Transforms/IPO/AttributorAttributes.cpp

llvm/lib/Transforms/Scalar/MergeICmps.cpp

llvm/lib/Transforms/Scalar/NewGVN.cpp

llvm/tools/llvm-exegesis/lib/PerfHelper.h

llvm/tools/llvm-exegesis/lib/PerfHelper.cpp

llvm/utils/TableGen/DecoderEmitter.cpp

[llvm][NFC] Apply performance-noexcept-move-constructor to llvm core
Needs ReviewPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List