This is an archive of the discontinued LLVM Phabricator instance.

[LoopUnroll] Don't update DT for changeToUnreachable.
ClosedPublic

Authored by fhahn on Jan 15 2023, 3:46 PM.

Details

Summary

There is no need to update the DT here, because there must be a unique
latch. Hence if the latch is not exiting it must directly branch back
to the original loop header and does not dominate any nodes.

Skipping a DT update here simplifies D141487.

Diff Detail

Event Timeline

fhahn created this revision.Jan 15 2023, 3:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 15 2023, 3:46 PM
fhahn requested review of this revision.Jan 15 2023, 3:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 15 2023, 3:46 PM
nikic accepted this revision.Jan 16 2023, 1:37 AM

LGTM

This revision is now accepted and ready to land.Jan 16 2023, 1:37 AM
This revision was landed with ongoing or failed builds.Jan 16 2023, 4:26 AM
This revision was automatically updated to reflect the committed changes.