test-release.sh: Only build native target for stage 1 and stage 2

[tstellar]

Summary

This will help speed up the builds.

[thieta]

Good change!

[amyk]

I've tested this on the PPC side. I am seeing object file differences at the end since we're no longer building for the native target for stage 3, for example:

# Comparing Phase 2 and Phase 3 files
file llvm-config.cpp.o differs between phase 2 and phase 3
file LTODisassembler.cpp.o differs between phase 2 and phase 3
file lto.cpp.o differs between phase 2 and phase 3
file llvm-ar.cpp.o differs between phase 2 and phase 3
file llvm-lto.cpp.o differs between phase 2 and phase 3
file DependencyScanningService.cpp.o differs between phase 2 and phase 3
file cc1as_main.cpp.o differs between phase 2 and phase 3
file driver.cpp.o differs between phase 2 and phase 3
file cc1_main.cpp.o differs between phase 2 and phase 3
file ClangLinkerWrapper.cpp.o differs between phase 2 and phase 3
file ClangCheck.cpp.o differs between phase 2 and phase 3
file CIndex.cpp.o differs between phase 2 and phase 3
file bugpoint.cpp.o differs between phase 2 and phase 3
file dsymutil.cpp.o differs between phase 2 and phase 3
file llc.cpp.o differs between phase 2 and phase 3
file disassemble.c.o differs between phase 2 and phase 3
file targets.c.o differs between phase 2 and phase 3
file llvm-cfi-verify.cpp.o differs between phase 2 and phase 3
file llvm-cxxdump.cpp.o differs between phase 2 and phase 3
file llvm-dwarfdump.cpp.o differs between phase 2 and phase 3
file llvm-dwarfutil.cpp.o differs between phase 2 and phase 3
file llvm-dwp.cpp.o differs between phase 2 and phase 3
file llvm-gsymutil.cpp.o differs between phase 2 and phase 3
file llvm-isel-fuzzer.cpp.o differs between phase 2 and phase 3
file llvm-jitlink.cpp.o differs between phase 2 and phase 3
file llvm-libtool-darwin.cpp.o differs between phase 2 and phase 3
file llvm-lto2.cpp.o differs between phase 2 and phase 3
file llvm-mc.cpp.o differs between phase 2 and phase 3
file llvm-mca.cpp.o differs between phase 2 and phase 3
file llvm-ml.cpp.o differs between phase 2 and phase 3
file llvm-nm.cpp.o differs between phase 2 and phase 3
file llvm-objdump.cpp.o differs between phase 2 and phase 3
file llvm-opt-fuzzer.cpp.o differs between phase 2 and phase 3
file llvm-profgen.cpp.o differs between phase 2 and phase 3
file ReducerWorkItem.cpp.o differs between phase 2 and phase 3
file llvm-rtdyld.cpp.o differs between phase 2 and phase 3
file opt.cpp.o differs between phase 2 and phase 3
file sancov.cpp.o differs between phase 2 and phase 3

Are others also seeing this issue with this change?

[thieta]

I haven't tried the change - but the errors here makes sense. I bet those objects have references to the other targets and they will differ when we disable anything but Native. If we want to keep these checks we probably need to build all targets for phase 2 or filter the list of objects to compare.

[tstellar]

I'm not sure I've every seen a build without file differences even without -DLLVM_TARGETS_TO_BUILD=Native. Is this check still useful? Alternatively we could only enable the Native target when the user passes the -no-compare-files option.

llvm/utils/release/test-release.sh

function configure_llvmCore() {
 
     if [ "$Phase" -eq "3" ]; then
       project_list=${projects// /;}
       # Leading spaces will result in ";<runtime name>". This causes a CMake
       # error because the empty string before the first ';' is treated as an
       # unknown runtime name.
       runtimes=$(echo $runtimes | sed -e 's/^\s*//')
       runtime_list=${runtimes// /;}
+      targets=""
     else
       project_list="clang"
       runtime_list=""
+      targets="-DLLVM_TARGETS_TO_BUILD=Native"
     fi
     echo "# Using C compiler: $c_compiler"
     echo "# Using C++ compiler: $cxx_compiler"
 
     cd $ObjDir
     echo "# Configuring llvm $Release-$RC $Flavor"
 
     echo "#" env CC="$c_compiler" CXX="$cxx_compiler" \
         cmake -G "$generator" \
         -DCMAKE_BUILD_TYPE=$BuildType -DLLVM_ENABLE_ASSERTIONS=$Assertions \
         -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
         -DLLVM_ENABLE_PROJECTS="$project_list" \
         -DLLVM_LIT_ARGS="-j $NumJobs" \
         -DLLVM_ENABLE_RUNTIMES="$runtime_list" \
-        $ExtraConfigureFlags $BuildDir/llvm-project/llvm \
+        $extra_flags $targets $BuildDir/llvm-project/llvm \
         2>&1 | tee $LogDir/llvm.configure-Phase$Phase-$Flavor.log
     env CC="$c_compiler" CXX="$cxx_compiler" \
         cmake -G "$generator" \
         -DCMAKE_BUILD_TYPE=$BuildType -DLLVM_ENABLE_ASSERTIONS=$Assertions \
         -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
         -DLLVM_ENABLE_PROJECTS="$project_list" \
         -DLLVM_LIT_ARGS="-j $NumJobs" \
         -DLLVM_ENABLE_RUNTIMES="$runtime_list" \
-        $ExtraConfigureFlags $BuildDir/llvm-project/llvm \
+        $extra_flags $targets $BuildDir/llvm-project/llvm \
         2>&1 | tee $LogDir/llvm.configure-Phase$Phase-$Flavor.log
 
     cd $BuildDir
 }
 
 function build_llvmCore() {
     Phase="$1"
     Flavor="$2"