This is an archive of the discontinued LLVM Phabricator instance.

[include-mapping] Print an error message in case the symbol index points to a non-existent page.
ClosedPublic

Authored by VitaNuo on Jan 12 2023, 7:39 AM.

Diff Detail

Event Timeline

VitaNuo created this revision.Jan 12 2023, 7:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 7:39 AM
Herald added a subscriber: arphaman. · View Herald Transcript
VitaNuo requested review of this revision.Jan 12 2023, 7:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 7:39 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
VitaNuo edited reviewers, added: kadircet; removed: hokein.
VitaNuo updated this revision to Diff 488653.Jan 12 2023, 7:47 AM

Change implementation from using "print" to using "sys.stderr.write".

kadircet accepted this revision.Jan 12 2023, 7:50 AM

thanks!

clang/tools/include-mapping/cppreference_parser.py
149

i think it's useful to mention the symbol name as well, maybe something like:

sys.stderr.write("Discarding information for '%s', page '%s' doesn't exist." % (symbol_name, path))

This revision is now accepted and ready to land.Jan 12 2023, 7:50 AM
VitaNuo updated this revision to Diff 488659.Jan 12 2023, 7:58 AM

Mention symbol name in the error message.

VitaNuo marked an inline comment as done.Jan 12 2023, 7:59 AM
This revision was landed with ongoing or failed builds.Jan 12 2023, 8:00 AM
This revision was automatically updated to reflect the committed changes.