This is an archive of the discontinued LLVM Phabricator instance.

[Mips] Convert some tests to opaque pointers (NFC)
ClosedPublic

Authored by nikic on Jan 12 2023, 3:43 AM.

Details

Summary

I'm not sure why, but the absence of bitcasts / no-op GEPs causes the branch delay slot to be used. I wanted to double check that this is correct.

Diff Detail

Event Timeline

nikic created this revision.Jan 12 2023, 3:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 3:43 AM
nikic requested review of this revision.Jan 12 2023, 3:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 3:43 AM
arichardson accepted this revision.Jan 13 2023, 1:07 AM

The difference in codegen is rather surprising, but looking at the diffs they are all semantically the same.

Comparing -debug output might explain why the delay slot can be filled now. I recall some issues with debug instructions but that should not be the case here. It's probably not worth investigating though.

This revision is now accepted and ready to land.Jan 13 2023, 1:07 AM
This revision was landed with ongoing or failed builds.Jan 13 2023, 1:34 AM
This revision was automatically updated to reflect the committed changes.