This is an archive of the discontinued LLVM Phabricator instance.

[llvm] Refactor leftover ThreadLocal usage in MinGW code
ClosedPublic

Authored by zero9178 on Jan 11 2023, 11:51 AM.

Details

Summary

This code was accidently left over after https://reviews.llvm.org/D141349 and now leads to compilation failure due to missing declaration (since the class has been removed)

Just migrate it by making use of LLVM_THREAD_LOCAL instead.

I am sadly currently not on my Windows machine (or one with a MinGW toolchain set up), so could not test this patch yet, just noticed the failure on an LLVM update in my projects CI. I'd appreciate it if someone could test compilation with MinGW, otherwise I'd do so on Friday.

Diff Detail

Event Timeline

zero9178 created this revision.Jan 11 2023, 11:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2023, 11:51 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
zero9178 requested review of this revision.Jan 11 2023, 11:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2023, 11:51 AM
zero9178 edited the summary of this revision. (Show Details)Jan 11 2023, 11:55 AM
nikic accepted this revision.Jan 11 2023, 12:21 PM
nikic added a subscriber: nikic.

LGTM

This revision is now accepted and ready to land.Jan 11 2023, 12:21 PM
mstorsjo accepted this revision.Jan 11 2023, 12:41 PM

LGTM, thanks!

resistor accepted this revision.Jan 11 2023, 12:42 PM
This revision was landed with ongoing or failed builds.Jan 11 2023, 12:47 PM
This revision was automatically updated to reflect the committed changes.