This is an archive of the discontinued LLVM Phabricator instance.

[flang] Fix cmake errors when building the Decimal and runtime libraries standalone
ClosedPublic

Authored by jpenix-quic on Jan 11 2023, 11:00 AM.

Details

Summary

Currently, cmake gives errors that check_cxx_compiler_flag and append are
unknown when building the Decimal and runtime libraries standalone. Add
the appropriate include resolve this.

Diff Detail

Event Timeline

jpenix-quic created this revision.Jan 11 2023, 11:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2023, 11:00 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
jpenix-quic requested review of this revision.Jan 11 2023, 11:00 AM
jeanPerier added inline comments.Jan 12 2023, 1:06 AM
flang/runtime/CMakeLists.txt
43

Isn't include(HandleLLVMOptions) enough given CheckCXXCompilerFlag seems to be already included by HandleLLVMOptions at [1] ?

[1]: https://github.com/llvm/llvm-project/blob/8d3ab9dfc4d49062e045d6d5db419975b81da7e4/llvm/cmake/modules/HandleLLVMOptions.cmake#L13

jpenix-quic edited the summary of this revision. (Show Details)

Remove unnecessary include(CheckCXXCompilerFlag)s

jpenix-quic added inline comments.Jan 12 2023, 9:49 AM
flang/runtime/CMakeLists.txt
43

Oops, yep, HandleLLVMOptions is enough. Thanks for catching this!

jeanPerier accepted this revision.Jan 13 2023, 12:14 AM

Thanks, LGTM.

This revision is now accepted and ready to land.Jan 13 2023, 12:14 AM