This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Don't expand printf users if printf is defined
ClosedPublic

Authored by arsenm on Jan 10 2023, 2:04 PM.

Download Raw Diff

Details

Reviewers

sameerds
vikramRH

Group Reviewers

Restricted Project

Diff Detail

Event Timeline

arsenm created this revision.Jan 10 2023, 2:04 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 10 2023, 2:04 PM

Herald added subscribers: kosarev, foad, kerbowa and 6 others. · View Herald Transcript

arsenm requested review of this revision.Jan 10 2023, 2:04 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 10 2023, 2:04 PM

Herald added a subscriber: wdng. · View Herald Transcript

Harbormaster completed remote builds in B206932: Diff 487988.Jan 10 2023, 8:01 PM

sameerds accepted this revision.Jan 12 2023, 6:44 AM

This revision is now accepted and ready to land.Jan 12 2023, 6:44 AM

0e7a83f502497602bdba927bf82d14387ef28611

Revision Contents

Path

Size

llvm/

lib/

Target/

AMDGPU/

AMDGPUPrintfRuntimeBinding.cpp

2 lines

test/

CodeGen/

AMDGPU/

printf-defined.ll

20 lines

Diff 487988

llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp

	Show First 20 Lines • Show All 483 Lines • ▼ Show 20 Lines
	}			}

	bool AMDGPUPrintfRuntimeBindingImpl::run(Module &M) {			bool AMDGPUPrintfRuntimeBindingImpl::run(Module &M) {
	Triple TT(M.getTargetTriple());			Triple TT(M.getTargetTriple());
	if (TT.getArch() == Triple::r600)			if (TT.getArch() == Triple::r600)
	return false;			return false;

	auto PrintfFunction = M.getFunction("printf");			auto PrintfFunction = M.getFunction("printf");
	if (!PrintfFunction)			if (!PrintfFunction \|\| !PrintfFunction->isDeclaration())
	return false;			return false;

	for (auto &U : PrintfFunction->uses()) {			for (auto &U : PrintfFunction->uses()) {
	if (auto *CI = dyn_cast<CallInst>(U.getUser())) {			if (auto *CI = dyn_cast<CallInst>(U.getUser())) {
	if (CI->isCallee(&U))			if (CI->isCallee(&U))
	Printfs.push_back(CI);			Printfs.push_back(CI);
	}			}
	}			}
	Show All 33 Lines

llvm/test/CodeGen/AMDGPU/printf-defined.ll

This file was added.

				; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
				; RUN: opt -mtriple=amdgcn-- -passes=amdgpu-printf-runtime-binding -mcpu=fiji -S < %s \| FileCheck --check-prefix=GCN %s

				@format.str = private unnamed_addr addrspace(4) constant [8 x i8] c"arst %d\00", align 1

				define i32 @printf(ptr addrspace(4), ...) {
				; GCN-LABEL: @printf(
				; GCN-NEXT: ret i32 0
				;
				ret i32 0
				}

				define void @printf_caller(i32 %n) {
				; GCN-LABEL: @printf_caller(
				; GCN-NEXT: [[CALL:%.]] = call i32 @printf(ptr addrspace(4) @format.str, i32 [[N:%.]])
				; GCN-NEXT: ret void
				;
				%call = call i32 @printf(ptr addrspace(4) @format.str, i32 %n)
				ret void
				}