This is an archive of the discontinued LLVM Phabricator instance.

[mlir][tosa] Add uint16 to TOSA type support
ClosedPublic

Authored by rsuderman on Jan 9 2023, 5:56 PM.

Details

Summary

UInt16 is included as a required TOSA type for basic
operations. Added support as a TOSA Tensor.

Diff Detail

Event Timeline

rsuderman created this revision.Jan 9 2023, 5:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2023, 5:56 PM
rsuderman requested review of this revision.Jan 9 2023, 5:56 PM
NatashaKnk accepted this revision.Jan 10 2023, 11:39 AM
This revision is now accepted and ready to land.Jan 10 2023, 11:39 AM
This revision was automatically updated to reflect the committed changes.

I find in the TOSA dialect definition, there is Tosa_Int64 support. Is there any specific reason that we cannot add F64 in TOSA ? Just at:
https://github.com/llvm/llvm-project/blob/9dea83d4af0b532373f8a0384ce7a873ebf18e41/mlir/include/mlir/Dialect/Tosa/IR/TosaTypesBase.td#L88