Details

Reviewers

aykevl
dylanmckay
jacquesguan

Commits

rG4fa9dc948226: [AVR] Fix incorrect expansion of the pseudo 'ELPMBRdZ' instruction

Summary

The ELPM instruction has three forms:

form	feature
ELPM	hasELPM
ELPM Rd, Z	hasELPMX
ELPM Rd, Z+	hasELPMX

The second form is always used in the expansion of the pseudo
instruction ELPMBRdZ. But for devices without FeatureELPMX and
with only FeatureELPM, only the first form can be used.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

benshi001 created this revision.Jan 8 2023, 4:47 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2023, 4:47 AM

Herald added subscribers: Jim, hiraditya. · View Herald Transcript

benshi001 requested review of this revision.Jan 8 2023, 4:47 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2023, 4:47 AM

Herald added subscribers: llvm-commits, jacquesguan. · View Herald Transcript

benshi001 updated this revision to Diff 487163.Jan 8 2023, 4:48 AM

benshi001 added a parent revision: D141210: [AVR] Do not select unimplemented pseudo instructions.

benshi001 edited the summary of this revision. (Show Details)

benshi001 added inline comments.Jan 8 2023, 4:50 AM

llvm/test/CodeGen/AVR/elpm.ll
296	The only difference between `CHECK` and `NOX` is that `elpm rd, z` is replaced by `elpm + mov rd, r0`.

benshi001 edited the summary of this revision. (Show Details)Jan 8 2023, 4:52 AM

benshi001 edited the summary of this revision. (Show Details)

benshi001 edited the summary of this revision. (Show Details)Jan 8 2023, 4:54 AM

benshi001 updated this revision to Diff 487165.Jan 8 2023, 5:08 AM

benshi001 updated this revision to Diff 487167.Jan 8 2023, 5:15 AM

benshi001 added inline comments.Jan 8 2023, 5:20 AM

llvm/lib/Target/AVR/AVRInstrInfo.td
1747	`ELPMBRdZ` does not clobber the `Z` register.
llvm/test/CodeGen/AVR/elpm.ll
246	The only difference between `CHECK` and `NOX` is that `elpm rd, z` is replaced by `elpm` + `mov rd, r0`.