This is an archive of the discontinued LLVM Phabricator instance.

[libc] Mark public C++ functions noexcept
AbandonedPublic

Authored by gchatelet on Jan 5 2023, 3:03 AM.

Details

Reviewers
sivachandra

Diff Detail

Event Timeline

gchatelet created this revision.Jan 5 2023, 3:03 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 5 2023, 3:03 AM
gchatelet requested review of this revision.Jan 5 2023, 3:03 AM

These aren't the public headers, so this is only marking it noexcept in a context where we likely already build without exceptions. We also don't every query if a function is noexcept in the code base either for the same reason. So I'm not sure what this is accomplishing.

gchatelet abandoned this revision.Jan 6 2023, 1:10 AM
gchatelet added a subscriber: michaelrj.

These aren't the public headers, so this is only marking it noexcept in a context where we likely already build without exceptions. We also don't every query if a function is noexcept in the code base either for the same reason. So I'm not sure what this is accomplishing.

Correct. @michaelrj patch is the correct approach in this case then.