This is an archive of the discontinued LLVM Phabricator instance.

[lld-macho][nfc] Re-enable previously disabled test.
ClosedPublic

Authored by oontvoo on Jan 4 2023, 6:51 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rGe9c824239397: [lld-macho][nfc] Re-enable previously disabled test.
Summary

This check was previous disabled (in D139572) because the test kept failing on ARM64. The output from reported failure message
gave the impression that the bundle was created as an x86-64 bundle but upon further inspection, I believe that's
a bug in llvm-otool where it prints both -h and -f for both input files on ARM64.

So the "fix" here is to rewrite the test to run the two otool commands separately but concatenate the
output into one file for checking.

Tested this on all 3 platforms: Linux-x86-64, Mac x86-64 and Mac ARM64.

Diff Detail

Event Timeline

oontvoo created this revision.Jan 4 2023, 6:51 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 4 2023, 6:51 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
oontvoo requested review of this revision.Jan 4 2023, 6:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2023, 6:51 AM
oontvoo added a subscriber: thakis.Jan 4 2023, 6:56 AM
oontvoo edited the summary of this revision. (Show Details)Jan 4 2023, 6:58 AM
oontvoo edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Jan 4 2023, 9:40 AM
This revision was automatically updated to reflect the committed changes.