These options doesn't affect the AST generation, and clang will crash
(CreateOrDie in ASTContext) immedidately when the provided file are not existed.
Disable them in clangd to make clangd more robust.
Paths
| Differential D140960
[clangd] Disable backend-releated filelist compiler options. ClosedPublic Authored by hokein on Jan 4 2023, 1:44 AM.
Details Summary These options doesn't affect the AST generation, and clang will crash Disable them in clangd to make clangd more robust.
Diff Detail
Event TimelineComment Actions Thanks!
This revision is now accepted and ready to land.Jan 4 2023, 1:54 AM This revision was landed with ongoing or failed builds.Jan 4 2023, 4:04 AM Closed by commit rG68fe0674187d: [clangd] Disable backend-releated filelist compiler options. (authored by hokein). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 486232 clang-tools-extra/clangd/Compiler.cpp
clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
|
not sure this is strictly accurate, maybe weaken to "mostly affect codegen, and aren't relevant to clangd"
(e.g. the asan options can affect record layout maybe?)