This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Fix useDeprecatedPositionallyEncodedOperands errors.
ClosedPublic

Authored by jyknight on Jan 3 2023, 12:42 PM.

Details

Summary

This is a follow-on to https://reviews.llvm.org/D134073.

The errors in the R600 half were fixed previously in
https://reviews.llvm.org/D134078. Originally, I thought that the fixes
to the AMDGPU half would be tricky, but upon taking another look,
there were only a couple minor issues that needed fixing:

  1. Previously, buffer load instructions (BUFFER_LOAD_*_LDS_*) were

populating the vdata field in the instruction from the swz
operand. This was incorrect, but harmless, as when the LDS option is
set, the instruction does not use the vdata field.

  1. The BUFFER_STORE_LDS_DWORD_gfx90a instruction was populating

acc from the swz operand, because acc was set to ?. (I believe
that the intent here was to leave the instruction bit as an "unknown
value", but you can't do that except by setting the bits on Inst
directly). Also harmless, for the same reason.

Diff Detail

Event Timeline

jyknight created this revision.Jan 3 2023, 12:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2023, 12:42 PM
jyknight requested review of this revision.Jan 3 2023, 12:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2023, 12:42 PM
arsenm accepted this revision.Jan 3 2023, 12:45 PM
This revision is now accepted and ready to land.Jan 3 2023, 12:45 PM
This revision was landed with ongoing or failed builds.Jan 3 2023, 2:52 PM
This revision was automatically updated to reflect the committed changes.