This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Remove functional test from unit tests
ClosedPublic

Authored by gchatelet on Jan 3 2023, 8:19 AM.

Details

Summary

As discussed offline, let's remove this one as it's hard to test on the build bots.

Diff Detail

Event Timeline

gchatelet created this revision.Jan 3 2023, 8:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2023, 8:19 AM
Herald added a subscriber: mstojanovic. · View Herald Transcript
gchatelet requested review of this revision.Jan 3 2023, 8:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2023, 8:19 AM

If you want to keep this test but just not run it by default, can you put it in a separate target that the build bot doesn't run? I guess it's up to you.

btw, we should be able to remove nobuildkite from llvm/unittests/BUILD.bazel after this patch. (Or if we keep the test but put it in a separate target, move the tag to the new one). I can land that separately if you prefer.

courbet accepted this revision.Jan 4 2023, 2:33 AM
This revision is now accepted and ready to land.Jan 4 2023, 2:33 AM
This revision was automatically updated to reflect the committed changes.

If you want to keep this test but just not run it by default, can you put it in a separate target that the build bot doesn't run? I guess it's up to you.

btw, we should be able to remove nobuildkite from llvm/unittests/BUILD.bazel after this patch. (Or if we keep the test but put it in a separate target, move the tag to the new one). I can land that separately if you prefer.

Thx! I've submitted it separately as 8ec0a369675b8406460fac1f94a6f2d84b7c0bb4

llvm/unittests/tools/llvm-exegesis/CMakeLists.txt