[clang][Interp] Skip calling simple destructors

[tbaeder]

Summary

Calling them isn't needed if I understand correctly.

[erichkeane]

This still would have to call the destructors of base and member types, right? And this just means that it isn't user defined AND isn't deleted for some reason, so this doesn't mean 'trivial'.

[tbaeder]

What a shame. :(

[tbaeder]

I added the isTrivial() checks to the new version in https://reviews.llvm.org/D137070.

clang/lib/AST/Interp/ByteCodeExprGen.h

for (Scope::Local &Local : this->Ctx->Descriptors[*Idx]) {
       const Record *TypeRecord = Local.Desc->ElemRecord;
       if (!TypeRecord)
         continue;
 
       const auto *RDecl = dyn_cast<CXXRecordDecl>(TypeRecord->getDecl());
       if (!RDecl)
         continue;
 
+      if (!RDecl->hasSimpleDestructor()) {
         if (const auto *DtorDecl = RDecl->getDestructor()) {
           const Function *Dtor = this->Ctx->getFunction(DtorDecl);
           if (Dtor && Dtor->isConstexpr()) {
             assert(Dtor->hasThisPointer());
             assert(Dtor->getNumParams() == 1);
             // Emit destructor call.
             this->Ctx->emitGetPtrLocal(Local.Offset, DtorDecl);
             this->Ctx->emitCall(Dtor, DtorDecl);
           }
         }
       }
+    }
     this->Ctx->emitDestroy(*Idx, SourceInfo{});
   }
 
 protected:
   /// Index of the scope in the chain.
   std::optional<unsigned> Idx;
 };