This is an archive of the discontinued LLVM Phabricator instance.

Differential D140565

[Clang][CMake] Set up distribution target for Clang-BOLT
ClosedPublic

Authored by Amir on Dec 22 2022, 10:29 AM.

Details

Reviewers
phosek
beanz
Commits
rG42129deaa67b: [Clang][CMake] Set up distribution target for Clang-BOLT
Summary

Provide a way to install usable BOLT-optimized Clang
(clang + resource headers) using
ninja clang-bolt install-distribution with BOLT.cmake cache file
or ninja stage2-clang-bolt stage2-install-distribution
with BOLT-PGO.cmake cache file.

Diff Detail

Event Timeline

Amir created this revision.Dec 22 2022, 10:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2022, 10:29 AM
Herald added a subscriber: wenlei. · View Herald Transcript
Amir requested review of this revision.Dec 22 2022, 10:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2022, 10:29 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B204617: Diff 484885.Dec 22 2022, 10:30 AM
Amir added a parent revision: D139496: [CMake] Add perf profiling for clang-bolt.Jan 3 2023, 6:10 PM
Amir edited parent revisions, added: D139454: [CMake] Replace clang binary if using clang-bolt target; removed: D139496: [CMake] Add perf profiling for clang-bolt.Jan 24 2023, 1:35 PM
Amir added a reviewer: beanz.Jan 24 2023, 1:38 PM
phosek accepted this revision.Jan 26 2023, 1:17 AM

LGTM

This revision is now accepted and ready to land.Jan 26 2023, 1:17 AM
This revision was landed with ongoing or failed builds.Feb 7 2023, 3:06 PM
Closed by commit rG42129deaa67b: [Clang][CMake] Set up distribution target for Clang-BOLT (authored by Amir). · Explain Why
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rG42129deaa67b: [Clang][CMake] Set up distribution target for Clang-BOLT.

Revision Contents

PathSize
clang/
cmake/
caches/
8 lines
7 lines

Diff 495651

clang/cmake/caches/BOLT-PGO.cmake

set(LLVM_ENABLE_PROJECTS "bolt;clang;lld" CACHE STRING "") set(LLVM_ENABLE_PROJECTS "bolt;clang;lld" CACHE STRING "")
set(CLANG_BOOTSTRAP_TARGETS set(CLANG_BOOTSTRAP_TARGETS
stage2-clang-bolt stage2-clang-bolt
stage2-distribution
stage2-install-distribution
CACHE STRING "") CACHE STRING "")
set(BOOTSTRAP_CLANG_BOOTSTRAP_TARGETS set(BOOTSTRAP_CLANG_BOOTSTRAP_TARGETS
clang-bolt clang-bolt
distribution
install-distribution
CACHE STRING "") CACHE STRING "")
set(PGO_BUILD_CONFIGURATION ${CMAKE_CURRENT_LIST_DIR}/BOLT.cmake CACHE STRING "") set(PGO_BUILD_CONFIGURATION
${CMAKE_CURRENT_LIST_DIR}/BOLT.cmake
CACHE STRING "")
include(${CMAKE_CURRENT_LIST_DIR}/PGO.cmake) include(${CMAKE_CURRENT_LIST_DIR}/PGO.cmake)

clang/cmake/caches/BOLT.cmake

set(CMAKE_BUILD_TYPE Release CACHE STRING "") set(CMAKE_BUILD_TYPE Release CACHE STRING "")
set(CLANG_BOLT_INSTRUMENT ON CACHE BOOL "") set(CLANG_BOLT_INSTRUMENT ON CACHE BOOL "")
set(CLANG_BOLT_INSTRUMENT_PROJECTS "llvm" CACHE STRING "") set(CLANG_BOLT_INSTRUMENT_PROJECTS "llvm" CACHE STRING "")
set(CLANG_BOLT_INSTRUMENT_TARGETS "count" CACHE STRING "") set(CLANG_BOLT_INSTRUMENT_TARGETS "count" CACHE STRING "")
set(CMAKE_EXE_LINKER_FLAGS "-Wl,--emit-relocs,-znow" CACHE STRING "") set(CMAKE_EXE_LINKER_FLAGS "-Wl,--emit-relocs,-znow" CACHE STRING "")
set(CLANG_BOLT_INSTRUMENT_EXTRA_CMAKE_FLAGS "" CACHE STRING "") set(CLANG_BOLT_INSTRUMENT_EXTRA_CMAKE_FLAGS "" CACHE STRING "")
set(LLVM_ENABLE_PROJECTS "bolt;clang" CACHE STRING "") set(LLVM_ENABLE_PROJECTS "bolt;clang" CACHE STRING "")
set(LLVM_TARGETS_TO_BUILD Native CACHE STRING "") set(LLVM_TARGETS_TO_BUILD Native CACHE STRING "")
# setup toolchain
set(LLVM_INSTALL_TOOLCHAIN_ONLY ON CACHE BOOL "")
set(LLVM_DISTRIBUTION_COMPONENTS
clang
clang-resource-headers
CACHE STRING "")
# Disable function splitting enabled by default in GCC8+ # Disable function splitting enabled by default in GCC8+
if("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU") if("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fno-reorder-blocks-and-partition") set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fno-reorder-blocks-and-partition")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-reorder-blocks-and-partition") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-reorder-blocks-and-partition")
endif() endif()