.clang-tidy: disable misc-use-anonymous-namespace check.

[hokein]

Summary

The check gives warnings on static functions, this is allowed per LLVM
code style https://llvm.org/docs/CodingStandards.html#anonymous-namespaces

[sammccall]

Yeah, good call. Do you mind if I first use this as a trigger to start a thread about this style rule on discourse, though? I've been meaning to, it came up in a review recently.

I think there's a fair chance of changing the policy from "require static" to "allow either" or "require anon namespace", and having the issue "live" in clang-tidy might make for a more engaged discussion.

[hokein]

In D140532#4012879, @sammccall wrote:

Yeah, good call. Do you mind if I first use this as a trigger to start a thread about this style rule on discourse, though? I've been meaning to, it came up in a review recently.

sure, please go ahead. (I found that these warnings are annoying when editing the llvm code file).

I think there's a fair chance of changing the policy from "require static" to "allow either" or "require anon namespace", and having the issue "live" in clang-tidy might make for a more engaged discussion.

Yeah, the code style says require static, I think in practice we allow either.

.clang-tidy

-Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-const-correctness,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,-misc-no-recursion,readability-identifier-naming'
+Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-const-correctness,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,-misc-no-recursion,-misc-use-anonymous-namespace,readability-identifier-naming'
 CheckOptions:
   - key:             readability-identifier-naming.ClassCase
     value:           CamelCase
   - key:             readability-identifier-naming.EnumCase
     value:           CamelCase
   - key:             readability-identifier-naming.FunctionCase
     value:           camelBack
   # Exclude from scanning as this is an exported symbol used for fuzzing