This is an archive of the discontinued LLVM Phabricator instance.

clang-tidy/add_new_check.py: Adapt to use %check_clang_tidy in tests
ClosedPublic

Authored by mgehre on Oct 25 2015, 11:46 AM.

Reviewers

Commits

Summary

Adapt clang-tidy/add_new_check.py according to commit r251010 "Add %check_clang_tidy and %clang_tidy_diff"

mgehre retitled this revision from to clang-tidy/add_new_check.py: Adapt to use %check_clang_tidy in tests.

mgehre updated this object.

mgehre added a subscriber: cfe-commits.

LG. Thanks, totally missed this.

Thanks for the fix.

This revision is now accepted and ready to land.Oct 26 2015, 11:10 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

clang-tidy/

2 lines

	Show First 20 Lines • Show All 187 Lines • ▼ Show 20 Lines
	def write_test(module_path, module, check_name):			def write_test(module_path, module, check_name):
	check_name_dashes = module + '-' + check_name			check_name_dashes = module + '-' + check_name
	filename = os.path.normpath(			filename = os.path.normpath(
	os.path.join(module_path, '../../test/clang-tidy',			os.path.join(module_path, '../../test/clang-tidy',
	check_name_dashes + '.cpp'))			check_name_dashes + '.cpp'))
	print('Creating %s...' % filename)			print('Creating %s...' % filename)
	with open(filename, 'wb') as f:			with open(filename, 'wb') as f:
	f.write(			f.write(
	"""// RUN: %%python %%S/check_clang_tidy.py %%s %(check_name_dashes)s %%t			"""// RUN: %%check_clang_tidy %%s %(check_name_dashes)s %%t

	// FIXME: Add something that triggers the check here.			// FIXME: Add something that triggers the check here.
	void f();			void f();
	// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: function 'f' is insufficiently awesome [%(check_name_dashes)s]			// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: function 'f' is insufficiently awesome [%(check_name_dashes)s]

	// FIXME: Verify the applied fix.			// FIXME: Verify the applied fix.
	// * Make the CHECK patterns specific enough and try to make verified lines			// * Make the CHECK patterns specific enough and try to make verified lines
	// unique to avoid incorrect matches.			// unique to avoid incorrect matches.
	▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines