This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] add initialize() API to LoopEmitter to support post-constructor initialization
ClosedPublic

Authored by Peiming on Dec 20 2022, 5:11 PM.

Diff Detail

Event Timeline

Peiming created this revision.Dec 20 2022, 5:11 PM
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Dec 20 2022, 5:11 PM
Peiming added inline comments.Dec 20 2022, 5:12 PM
mlir/lib/Dialect/SparseTensor/Transforms/CodegenUtils.cpp
219–231

I know that this is not recommended, but it cause name collision between parameter and fields.

I can change the parameter names instead of using this if you prefer.

aartbik accepted this revision.Dec 20 2022, 5:13 PM
aartbik added inline comments.
mlir/lib/Dialect/SparseTensor/Transforms/CodegenUtils.h
581

I would move the comment from the constructor here, and document it as a setup, and then document the constructor as doing a direct setup. But just a suggestion, your call in the end.

This revision is now accepted and ready to land.Dec 20 2022, 5:13 PM
Peiming updated this revision to Diff 484432.Dec 20 2022, 5:16 PM

address comments.

This revision was landed with ongoing or failed builds.Dec 20 2022, 5:18 PM
This revision was automatically updated to reflect the committed changes.