This is an archive of the discontinued LLVM Phabricator instance.

[GlobalISel][Legalizer] add minScalarIf action
ClosedPublic

Authored by stuij on Dec 19 2022, 6:50 AM.

Details

Summary

Ensure scalar is at least as wide as type, but only if the specified condition
is met.

Diff Detail

Event Timeline

stuij created this revision.Dec 19 2022, 6:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2022, 6:50 AM
stuij requested review of this revision.Dec 19 2022, 6:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2022, 6:50 AM
arsenm added a subscriber: arsenm.Dec 19 2022, 7:13 AM
arsenm added inline comments.
llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h
966

Should only use changeElementTo if this handles vectors, which it doesn't. Use changeTo or make minScalarOrEltIf

stuij updated this revision to Diff 483961.Dec 19 2022, 7:24 AM

addressed review comment

stuij marked an inline comment as done.Dec 19 2022, 7:25 AM
stuij added inline comments.
llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h
966

thanks! done.

This revision is now accepted and ready to land.Dec 21 2022, 2:28 PM
This revision was landed with ongoing or failed builds.Dec 22 2022, 8:21 AM
This revision was automatically updated to reflect the committed changes.
stuij marked an inline comment as done.