This is an archive of the discontinued LLVM Phabricator instance.

[lld-macho][test][nfc] Update stabs.s to use GMT time zone instead of UTC
ClosedPublic

Authored by pzheng on Dec 16 2022, 10:49 AM.

Details

Summary

This is to work around a singularity container issue we ran into recently. The
container fails to honor the time zone setting (TZ=UTC) when executing the touch
command. Replacing UTC with GMT worked correctly in the container. This change
does not change (at least not intentionally) the function of the test in any way
since GMT and UTC should be equivalent AFAIK. Please refer to the discussions in
D139980 for more background information.

Diff Detail

Event Timeline

pzheng created this revision.Dec 16 2022, 10:49 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 16 2022, 10:49 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
pzheng requested review of this revision.Dec 16 2022, 10:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2022, 10:49 AM
int3 accepted this revision.Dec 22 2022, 1:20 PM

Let's try it. Please watch the buildbots when it lands & fast revert if necessary

This revision is now accepted and ready to land.Dec 22 2022, 1:20 PM

Sure, I'll monitor the buildbot in case this causes any failures.

As requested on the other review, please also report this problem upstream to your container vendor, so that eventually workarounds like this are hopefully no longer needed.

Sure, @thakis. We are working with our IT department to get to the bottom of this and will report the issue to the container vendor if IT concludes it's a container bug.