This is an archive of the discontinued LLVM Phabricator instance.

[Bitcode] Remove auto-detection for typed pointers
ClosedPublic

Authored by nikic on Dec 13 2022, 8:17 AM.

Details

Reviewers
arsenm
aeubanks
Group Reviewers
Restricted Project
Commits
rGe45cf479231f: [Bitcode] Remove auto-detection for typed pointers
Summary

Always read bitcode according to the -opaque-pointers mode. Do not perform auto-detection to implicitly switch to typed pointers.

This is a step towards removing typed pointer support, and also eliminates the class of problems where linking may fail if a typed pointer module is loaded before an opaque pointer module. (The latest place where this was encountered is https://reviews.llvm.org/D139924, but this has previously been fixed in other places doing bitcode linking as well.)

PS: This currently still fails a small handful of tests, which I'll update before landing this.

Diff Detail

Event Timeline

nikic created this revision.Dec 13 2022, 8:17 AM
nikic requested review of this revision.Dec 13 2022, 8:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2022, 8:17 AM
arsenm accepted this revision.Dec 13 2022, 8:34 AM
This revision is now accepted and ready to land.Dec 13 2022, 8:34 AM
aeubanks accepted this revision.Dec 13 2022, 9:12 AM
This revision was landed with ongoing or failed builds.Dec 14 2022, 4:39 AM
This revision was automatically updated to reflect the committed changes.