Page MenuHomePhabricator
Differential D139862

[llvm][Object] set SF_Hidden flag for MachO files
ClosedPublic
Actions

Authored by cishida on Dec 12 2022, 10:54 AM.

Details

Reviewers
pete
ributzka
steven_wu
Group Reviewers
Restricted Project
Commits
rGac20a3a5b530: [llvm][Object] set SF_Hidden flag for MachO files

Diff Detail

Event Timeline

cishida created this revision.Dec 12 2022, 10:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2022, 10:54 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
cishida requested review of this revision.Dec 12 2022, 10:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2022, 10:54 AM
Harbormaster completed remote builds in B202629: Diff 482191.Dec 12 2022, 12:25 PM
pete accepted this revision.Dec 12 2022, 3:29 PM

LGTM

This revision is now accepted and ready to land.Dec 12 2022, 3:29 PM
ributzka added a comment.Dec 12 2022, 3:38 PM

Test case?

cishida updated this revision to Diff 482537.Dec 13 2022, 10:05 AM

Update lld tests to include .hidden attribute.

Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2022, 10:05 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: ormris. · View Herald Transcript
ributzka accepted this revision.Dec 13 2022, 10:15 AM

LGTM

Harbormaster completed remote builds in B202890: Diff 482537.Dec 13 2022, 11:54 AM
This revision was landed with ongoing or failed builds.Dec 13 2022, 2:59 PM
Closed by commit rGac20a3a5b530: [llvm][Object] set SF_Hidden flag for MachO files (authored by cishida). · Explain Why
This revision was automatically updated to reflect the committed changes.
cishida added a commit: rGac20a3a5b530: [llvm][Object] set SF_Hidden flag for MachO files.

Revision Contents
Changeset List

PathSize
lld/
test/
MachO/
6 lines
2 lines
8 lines
llvm/
lib/
Object/
8 lines

Diff 482637

View Options

lld/test/MachO/alias-symbols.s

Loading...
View Options

lld/test/MachO/lto-explicit-exports.ll

Loading...
View Options

lld/test/MachO/weak-definition-gc.s

Loading...
View Options

llvm/lib/Object/MachOObjectFile.cpp

Loading...