[ADT] Remove Optional<T>::create

[kazu]

Summary

The last use of Optional<T>::create was removed on December 10, 2022
in commit 1cb7fba3e57d6c31f05c7a2bda1634da49dd1d18.

[MaskRay]

https://sourcegraph.com/search?q=context:global+Optional%3C%5B%5E%3E%5D%2B%3E::create+-f:clang/lib+-f:lib/StaticAnalyzer/&patternType=regexp&sm=0

This API seems unused outside llvm-project, so I think it can just be removed instead of going through a deprecated state.

[kazu]

Remove the function instead.

[kazu]

In D139775#3987989, @MaskRay wrote:

https://sourcegraph.com/search?q=context:global+Optional%3C%5B%5E%3E%5D%2B%3E::create+-f:clang/lib+-f:lib/StaticAnalyzer/&patternType=regexp&sm=0

This API seems unused outside llvm-project, so I think it can just be removed instead of going through a deprecated state.

OK. I've updated the patch. PTAL. Thanks!

[kazu]

Friendly ping. I'm going for simple removal as @MaskRay has suggested.

There were so few users within LLVM. Probably there are very few out there among downstream users, too.

llvm/include/llvm/ADT/Optional.h

public:
   }
   Optional &operator=(Optional &&O) = default;
 
   /// Create a new object by constructing it in place with the given arguments.
   template <typename... ArgTypes> void emplace(ArgTypes &&... Args) {
     Storage.emplace(std::forward<ArgTypes>(Args)...);
   }
 
-  static constexpr Optional create(const T *y) {
-    return y ? Optional(*y) : Optional();
-  }
-
   Optional &operator=(const T &y) {
     Storage = y;
     return *this;
   }
   Optional &operator=(const Optional &O) = default;
 
   void reset() { Storage.reset(); }