This is an archive of the discontinued LLVM Phabricator instance.

Differential D139754

[llvm][perf] fix a compiler warning when compile LLVM with LLVM_USE_PERF.
ClosedPublic

Authored by Peiming on Dec 9 2022, 4:57 PM.

Details

Reviewers
nhaehnle
ezhulenev
sylvestre.ledru
Commits
rG198a253715fb: [llvm][perf] fix a compiler warning when compile LLVM with LLVM_USE_PERF.
Summary

To fix "PerfJITEventListener.cpp:208:32: warning: missing field 'Version' initializer [-Wmissing-field-initializers]"

Diff Detail

Unit TestsFailed

TimeTest
60,030 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test

Event Timeline

Peiming created this revision.Dec 9 2022, 4:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2022, 4:57 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
Peiming requested review of this revision.Dec 9 2022, 4:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2022, 4:57 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Peiming edited the summary of this revision. (Show Details)Dec 9 2022, 4:57 PM
Peiming added reviewers: nhaehnle, ezhulenev.Dec 9 2022, 5:01 PM
Peiming added a reviewer: sylvestre.ledru.Dec 9 2022, 5:04 PM
Harbormaster completed remote builds in B202337: Diff 481791.Dec 9 2022, 6:05 PM
ezhulenev accepted this revision.Dec 9 2022, 7:52 PM
This revision is now accepted and ready to land.Dec 9 2022, 7:52 PM
Peiming updated this revision to Diff 481827.Dec 9 2022, 9:49 PM

rebase

This revision was landed with ongoing or failed builds.Dec 9 2022, 9:53 PM
Closed by commit rG198a253715fb: [llvm][perf] fix a compiler warning when compile LLVM with LLVM_USE_PERF. (authored by Peiming). · Explain Why
This revision was automatically updated to reflect the committed changes.
Peiming added a commit: rG198a253715fb: [llvm][perf] fix a compiler warning when compile LLVM with LLVM_USE_PERF..
Harbormaster completed remote builds in B202366: Diff 481827.Dec 9 2022, 10:48 PM

Revision Contents

PathSize
llvm/
lib/
ExecutionEngine/
PerfJITEvents/
2 lines

Diff 481791

llvm/lib/ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp

Show First 20 Lines • Show All 199 Lines • ▼ Show 20 Lines if (auto EC =
sys::fs::CD_CreateNew, sys::fs::OF_None)) { sys::fs::CD_CreateNew, sys::fs::OF_None)) {
errs() << "could not open JIT dump file " << FilenameBuf.str() << ": " errs() << "could not open JIT dump file " << FilenameBuf.str() << ": "
<< EC.message() << "\n"; << EC.message() << "\n";
return; return;
} }
Dumpstream = std::make_unique<raw_fd_ostream>(DumpFd, true); Dumpstream = std::make_unique<raw_fd_ostream>(DumpFd, true);
LLVMPerfJitHeader Header = {0}; LLVMPerfJitHeader Header = {0, 0, 0, 0, 0, 0, 0, 0};
if (!FillMachine(Header)) if (!FillMachine(Header))
return; return;
// signal this process emits JIT information // signal this process emits JIT information
if (!OpenMarker()) if (!OpenMarker())
return; return;
// emit dumpstream header // emit dumpstream header
▲ Show 20 Lines • Show All 289 Lines • Show Last 20 Lines