This is an archive of the discontinued LLVM Phabricator instance.

[Clang]Use poison instead of undef where its used as placeholder[NFC]
ClosedPublic

Authored by ManuelJBrito on Dec 9 2022, 3:22 PM.

Details

Summary

Replacing the following instances of undef with poison where undef is used as a placeholder for aggregate construction.

Diff Detail

Event Timeline

ManuelJBrito created this revision.Dec 9 2022, 3:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2022, 3:22 PM
ManuelJBrito requested review of this revision.Dec 9 2022, 3:22 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
nikic added a subscriber: nikic.Dec 10 2022, 12:49 AM

The struct/insertvalue changes here are fine (no change in semantics). Can't comment on the vector/insertelement changes, you might want to split them out.

ManuelJBrito retitled this revision from Use poison instead of undef where its used as placeholder[NFC] to [Clang]Use poison instead of undef where its used as placeholder[NFC].

Splitting the diff

nlopes accepted this revision.Dec 11 2022, 8:14 AM

LGTM

This revision is now accepted and ready to land.Dec 11 2022, 8:14 AM
This revision was landed with ongoing or failed builds.Dec 11 2022, 8:18 AM
This revision was automatically updated to reflect the committed changes.