This is an archive of the discontinued LLVM Phabricator instance.

[mlir][LLVMIR target] Fix llvm.freeze builder to prevent crashes
ClosedPublic

Authored by krzysz00 on Dec 7 2022, 1:07 PM.

Details

Summary

The freeze builder did not assign the result of creating the freeze
operation to $res, which meant that when subsequent translations (such
as a sext) tried to use that result or query its type, mlir-translate
would crash.

This fixes the issue and adds a test for it.

Diff Detail

Event Timeline

krzysz00 created this revision.Dec 7 2022, 1:07 PM
Herald added a project: Restricted Project. · View Herald Transcript
krzysz00 requested review of this revision.Dec 7 2022, 1:07 PM
ftynse accepted this revision.Dec 12 2022, 11:42 AM
This revision is now accepted and ready to land.Dec 12 2022, 11:42 AM