This is an archive of the discontinued LLVM Phabricator instance.

[libc++][Android] Disable pbump2gig for Android
ClosedPublic

Authored by rprichard on Dec 6 2022, 8:28 PM.

Details

Reviewers
danalbert
Mordante
Group Reviewers
Restricted Project
Commits
rG5df7b45ae4b5: [libc++][Android] Disable pbump2gig for Android
Summary

Android devices frequently don't have enough memory to run this test.

e.g. On the API 33 x86-64 emulator with 2GiB RAM, the test triggers the
OOM Killer, the device reboots, and then adb shell exits with status
0 and no output.

Diff Detail

Event Timeline

rprichard created this revision.Dec 6 2022, 8:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2022, 8:28 PM
rprichard requested review of this revision.Dec 6 2022, 8:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2022, 8:28 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision.Dec 7 2022, 9:02 AM
Mordante added a subscriber: Mordante.

I see the AIX CI fail. I assume it's unrelated, can you re-upload your patch to verify.
LGTM from libc++'s perspective, but please wait for @danalbert's approval and a green CI.

This revision is now accepted and ready to land.Dec 7 2022, 9:02 AM
rprichard updated this revision to Diff 480967.Dec 7 2022, 10:25 AM

No change.

danalbert accepted this revision.Dec 7 2022, 10:28 AM

LGTM, but note that rprichard is going to be a better POC for Android libc++ in the future :)

rprichard updated this revision to Diff 480972.Dec 7 2022, 10:36 AM

Bump BuildKite again.

LGTM, but note that rprichard is going to be a better POC for Android libc++ in the future :)

Thanks for the information.

This revision was landed with ongoing or failed builds.Dec 9 2022, 3:16 PM
This revision was automatically updated to reflect the committed changes.