This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] Replace vector.print with printMemref for some tests.
ClosedPublic

Authored by bixia on Dec 6 2022, 5:00 PM.

Diff Detail

Event Timeline

bixia created this revision.Dec 6 2022, 5:00 PM
Herald added a project: Restricted Project. · View Herald Transcript
bixia requested review of this revision.Dec 6 2022, 5:00 PM
aartbik added inline comments.Dec 6 2022, 5:28 PM
mlir/test/Integration/Dialect/SparseTensor/CPU/concatenate.mlir
329

here and below, any reason the -NEXT needed to be dropped?
trying to visualize what changed here

bixia added inline comments.Dec 7 2022, 8:28 AM
mlir/test/Integration/Dialect/SparseTensor/CPU/concatenate.mlir
329

printMemref starts with a meta data line, in this case, it is
Memref base@ = 0x35aebc0ca800 rank = 1 offset = 0 sizes = [32] strides = [1] data =

we can add a CHECK-NEXT line to connect this if that is what we want.

bixia updated this revision to Diff 481090.Dec 7 2022, 3:39 PM

Convert more tests.

bixia retitled this revision from [mlir][sparse] Replace vector.print with printMemRef for a test. to [mlir][sparse] Replace vector.print with printMemref for some tests..Dec 7 2022, 3:40 PM
aartbik accepted this revision.Dec 9 2022, 3:58 PM
This revision is now accepted and ready to land.Dec 9 2022, 3:58 PM