This is an archive of the discontinued LLVM Phabricator instance.

Differential D139318

ValueTracking: Teach isKnownNeverInfinity about llvm.sin/llvm.cos
ClosedPublic

Authored by arsenm on Dec 5 2022, 5:35 AM.

Details

Reviewers
spatel
kpn
andrew.w.kaylor
sepavloff
nlopes

Diff Detail

Event Timeline

arsenm created this revision.Dec 5 2022, 5:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2022, 5:35 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
arsenm requested review of this revision.Dec 5 2022, 5:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2022, 5:35 AM
Herald added a subscriber: wdng. · View Herald Transcript
Harbormaster completed remote builds in B201090: Diff 480073.Dec 5 2022, 5:35 AM
arsenm added a child revision: D139320: ValueTracking: Document some difficult isKnownNeverInfinity cases.Dec 5 2022, 5:39 AM
kpn accepted this revision.Dec 5 2022, 1:22 PM

LGTM

This revision is now accepted and ready to land.Dec 5 2022, 1:22 PM
arsenm closed this revision.Dec 20 2022, 10:17 AM

2bf17cc0482c6928ded4ee8096ded648a766f2aa

Revision Contents

Diff 480073

llvm/lib/Analysis/ValueTracking.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 3,801 Lines • ▼ Show 20 Lines case Instruction::FPExt: {
return isKnownNeverInfinity(Inst->getOperand(0), TLI, Depth + 1); return isKnownNeverInfinity(Inst->getOperand(0), TLI, Depth + 1);
} }
default: default:
break; break;
} }
if (const auto *II = dyn_cast<IntrinsicInst>(V)) { if (const auto *II = dyn_cast<IntrinsicInst>(V)) {
switch (II->getIntrinsicID()) { switch (II->getIntrinsicID()) {
case Intrinsic::sin:
case Intrinsic::cos:
// Return NaN on infinite inputs.
return true;
case Intrinsic::fabs: case Intrinsic::fabs:
case Intrinsic::sqrt: case Intrinsic::sqrt:
case Intrinsic::canonicalize: case Intrinsic::canonicalize:
case Intrinsic::copysign: case Intrinsic::copysign:
case Intrinsic::arithmetic_fence: case Intrinsic::arithmetic_fence:
case Intrinsic::floor: case Intrinsic::floor:
case Intrinsic::ceil: case Intrinsic::ceil:
case Intrinsic::trunc: case Intrinsic::trunc:
▲ Show 20 Lines • Show All 3,671 Lines • Show Last 20 Lines

llvm/test/Transforms/InstSimplify/floating-point-compare.ll

Show First 20 Lines • Show All 1,723 Lines • ▼ Show 20 Lines;
ret i1 %r ret i1 %r
} }
declare double @llvm.sqrt.f64(double) declare double @llvm.sqrt.f64(double)
; No source check required ; No source check required
define i1 @isKnownNeverInfinity_sin(double %x) { define i1 @isKnownNeverInfinity_sin(double %x) {
; CHECK-LABEL: @isKnownNeverInfinity_sin( ; CHECK-LABEL: @isKnownNeverInfinity_sin(
; CHECK-NEXT: [[E:%.*]] = call double @llvm.sin.f64(double [[X:%.*]]) ; CHECK-NEXT: ret i1 true
; CHECK-NEXT: [[R:%.*]] = fcmp une double [[E]], 0x7FF0000000000000
; CHECK-NEXT: ret i1 [[R]]
; ;
%e = call double @llvm.sin.f64(double %x) %e = call double @llvm.sin.f64(double %x)
%r = fcmp une double %e, 0x7ff0000000000000 %r = fcmp une double %e, 0x7ff0000000000000
ret i1 %r ret i1 %r
} }
declare double @llvm.sin.f64(double) declare double @llvm.sin.f64(double)
; No source check required ; No source check required
define i1 @isKnownNeverInfinity_cos(double %x) { define i1 @isKnownNeverInfinity_cos(double %x) {
; CHECK-LABEL: @isKnownNeverInfinity_cos( ; CHECK-LABEL: @isKnownNeverInfinity_cos(
; CHECK-NEXT: [[E:%.*]] = call double @llvm.cos.f64(double [[X:%.*]]) ; CHECK-NEXT: ret i1 true
; CHECK-NEXT: [[R:%.*]] = fcmp une double [[E]], 0x7FF0000000000000
; CHECK-NEXT: ret i1 [[R]]
; ;
%e = call double @llvm.cos.f64(double %x) %e = call double @llvm.cos.f64(double %x)
%r = fcmp une double %e, 0x7ff0000000000000 %r = fcmp une double %e, 0x7ff0000000000000
ret i1 %r ret i1 %r
} }
declare double @llvm.cos.f64(double) declare double @llvm.cos.f64(double)