This is an archive of the discontinued LLVM Phabricator instance.

Differential D139248

[lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod
ClosedPublic

Authored by mib on Dec 2 2022, 11:45 PM.

Details

Reviewers
JDevlieghere
kastiglione
Commits
rG3fbc89048517: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod
Summary

This patch makes ScriptedPythonInterface::GetStatusFromMethod take a
parameter pack as an argument. That will allow it to pass arbitrary
arguments to the python method.

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>

Diff Detail

Event Timeline

mib created this revision.Dec 2 2022, 11:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2022, 11:45 PM
mib requested review of this revision.Dec 2 2022, 11:45 PM
Herald added a subscriber: lldb-commits. · View Herald TranscriptDec 2 2022, 11:45 PM
mib added a parent revision: D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic.Dec 2 2022, 11:46 PM
Harbormaster completed remote builds in B200890: Diff 479806.Dec 2 2022, 11:48 PM
mib added a child revision: D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance.Dec 2 2022, 11:49 PM
JDevlieghere accepted this revision.Dec 5 2022, 9:36 AM

Makes sense, LGTM.

This revision is now accepted and ready to land.Dec 5 2022, 9:36 AM
labath added a subscriber: labath.Dec 15 2022, 2:01 PM
labath added inline comments.
lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h
106

std::forward<Args>(args)... maybe?

mib marked an inline comment as done.Dec 16 2022, 6:16 AM
mib added inline comments.
lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h
106

Indeed, thanks!

mib updated this revision to Diff 484527.Dec 21 2022, 4:14 AM
mib marked an inline comment as done.

Use std::forward

Harbormaster completed remote builds in B204355: Diff 484527.Dec 21 2022, 4:18 AM
Closed by commit rG3fbc89048517: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod (authored by mib). · Explain WhyJan 12 2023, 12:54 PM
This revision was automatically updated to reflect the committed changes.
mib added a commit: rG3fbc89048517: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod.

Revision Contents

PathSize
lldb/
source/
Plugins/
ScriptInterpreter/
Python/
8 lines
8 lines

Diff 488744

lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h

Show First 20 Lines • Show All 94 Lines • ▼ Show 20 Lines if (sizeof...(Args) > 0)
if (!ReassignPtrsOrRefsArgs(original_args, transformed_args)) if (!ReassignPtrsOrRefsArgs(original_args, transformed_args))
return ErrorWithMessage<T>( return ErrorWithMessage<T>(
caller_signature, caller_signature,
"Couldn't re-assign reference and pointer arguments.", error); "Couldn't re-assign reference and pointer arguments.", error);
return ExtractValueFromPythonObject<T>(py_return, error); return ExtractValueFromPythonObject<T>(py_return, error);
} }
Status GetStatusFromMethod(llvm::StringRef method_name); template <typename... Args>
Status GetStatusFromMethod(llvm::StringRef method_name, Args &&...args) {
Status error;
Dispatch<Status>(method_name, error, std::forward<Args>(args)...);
labathUnsubmitted
Done
ReplyInline Actions

std::forward<Args>(args)... maybe?

labath: `std::forward<Args>(args)...` maybe?
mibAuthorUnsubmitted
Done
ReplyInline Actions

Indeed, thanks!

mib: Indeed, thanks!
return error;
}
template <typename T> T Transform(T object) { template <typename T> T Transform(T object) {
// No Transformation for generic usage // No Transformation for generic usage
return {object}; return {object};
} }
python::PythonObject Transform(Status arg) { python::PythonObject Transform(Status arg) {
return python::ToSWIGWrapper(arg); return python::ToSWIGWrapper(arg);
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines

lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp

Show All 21 Lines
using namespace lldb; using namespace lldb;
using namespace lldb_private; using namespace lldb_private;
ScriptedPythonInterface::ScriptedPythonInterface( ScriptedPythonInterface::ScriptedPythonInterface(
ScriptInterpreterPythonImpl &interpreter) ScriptInterpreterPythonImpl &interpreter)
: ScriptedInterface(), m_interpreter(interpreter) {} : ScriptedInterface(), m_interpreter(interpreter) {}
Status
ScriptedPythonInterface::GetStatusFromMethod(llvm::StringRef method_name) {
Status error;
Dispatch<Status>(method_name, error);
return error;
}
template <> template <>
StructuredData::ArraySP StructuredData::ArraySP
ScriptedPythonInterface::ExtractValueFromPythonObject<StructuredData::ArraySP>( ScriptedPythonInterface::ExtractValueFromPythonObject<StructuredData::ArraySP>(
python::PythonObject &p, Status &error) { python::PythonObject &p, Status &error) {
python::PythonList result_list(python::PyRefType::Borrowed, p.get()); python::PythonList result_list(python::PyRefType::Borrowed, p.get());
return result_list.CreateStructuredArray(); return result_list.CreateStructuredArray();
} }
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines