This is an archive of the discontinued LLVM Phabricator instance.

Differential D143122

[lldb/python] Fix scripted_platform python module creation
ClosedPublic

Authored by mib on Feb 1 2023, 4:33 PM.

Details

Reviewers
bulbazord
Commits
rG35ef899f94eb: [lldb/python] Fix scripted_platform python module creation
Summary

This patch should fix the creation and addition of the scripted_platform
python module into the lldb.plugins module.

Previously, we were creating the plugins submodule, each time with a
different source file (either scripted_process or scripted_platform).

The removes the redundant create_python_package call and group both
python source files toghether.

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>

Diff Detail

Event Timeline

mib created this revision.Feb 1 2023, 4:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2023, 4:33 PM
Herald added a subscriber: JDevlieghere. · View Herald Transcript
mib requested review of this revision.Feb 1 2023, 4:33 PM
Herald added a subscriber: lldb-commits. · View Herald TranscriptFeb 1 2023, 4:33 PM
bulbazord accepted this revision.Feb 1 2023, 4:34 PM
This revision is now accepted and ready to land.Feb 1 2023, 4:34 PM
mib added a parent revision: D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess.Feb 1 2023, 4:38 PM
Harbormaster completed remote builds in B211350: Diff 494113.Feb 1 2023, 4:41 PM
mib added a child revision: D143213: [lldb/Plugins] Introduce Multiplexer & ScriptedMultiplexer.Feb 2 2023, 1:27 PM
Closed by commit rG35ef899f94eb: [lldb/python] Fix scripted_platform python module creation (authored by mib). · Explain WhyFeb 2 2023, 3:23 PM
This revision was automatically updated to reflect the committed changes.
mib added a commit: rG35ef899f94eb: [lldb/python] Fix scripted_platform python module creation.

Revision Contents

PathSize
lldb/
bindings/
python/
8 lines

Diff 494448

lldb/bindings/python/CMakeLists.txt

Show First 20 Lines • Show All 97 Lines • ▼ Show 20 Lines create_python_package(
FILES "${LLDB_SOURCE_DIR}/examples/python/in_call_stack.py" FILES "${LLDB_SOURCE_DIR}/examples/python/in_call_stack.py"
"${LLDB_SOURCE_DIR}/examples/python/symbolication.py") "${LLDB_SOURCE_DIR}/examples/python/symbolication.py")
create_python_package( create_python_package(
${swig_target} ${swig_target}
${lldb_python_target_dir} ${lldb_python_target_dir}
"plugins" "plugins"
FILES FILES
"${LLDB_SOURCE_DIR}/examples/python/scripted_process/scripted_process.py") "${LLDB_SOURCE_DIR}/examples/python/scripted_process/scripted_process.py"
create_python_package(
${swig_target}
${lldb_python_target_dir}
"plugins"
FILES
"${LLDB_SOURCE_DIR}/examples/python/scripted_process/scripted_platform.py") "${LLDB_SOURCE_DIR}/examples/python/scripted_process/scripted_platform.py")
if(APPLE) if(APPLE)
create_python_package( create_python_package(
${swig_target} ${swig_target}
${lldb_python_target_dir} "macosx" ${lldb_python_target_dir} "macosx"
FILES "${LLDB_SOURCE_DIR}/examples/python/crashlog.py" FILES "${LLDB_SOURCE_DIR}/examples/python/crashlog.py"
"${LLDB_SOURCE_DIR}/examples/python/scripted_process/crashlog_scripted_process.py" "${LLDB_SOURCE_DIR}/examples/python/scripted_process/crashlog_scripted_process.py"
▲ Show 20 Lines • Show All 78 Lines • Show Last 20 Lines