This is an archive of the discontinued LLVM Phabricator instance.

Differential D139202

Link with missing libs to fix broken shared build
ClosedPublic

Authored by junaire on Dec 2 2022, 7:36 AM.

Details

Reviewers
sammccall
aaron.ballman
Commits
rG8431436e543f: Link with missing libs to fix broken shared build
Summary

Signed-off-by: Jun Zhang <jun@junz.org>

Diff Detail

Event Timeline

junaire created this revision.Dec 2 2022, 7:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2022, 7:36 AM
Herald added a subscriber: kadircet. · View Herald Transcript
junaire requested review of this revision.Dec 2 2022, 7:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2022, 7:36 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
junaire added reviewers: sammccall, aaron.ballman.Dec 2 2022, 7:37 AM
junaire added a comment.Dec 2 2022, 7:39 AM

This is caused by https://reviews.llvm.org/D139013 I should mention.

sammccall accepted this revision.Dec 2 2022, 7:54 AM

Thanks, and sorry for the breakage!

This revision is now accepted and ready to land.Dec 2 2022, 7:54 AM
This revision was landed with ongoing or failed builds.Dec 2 2022, 8:02 AM
Closed by commit rG8431436e543f: Link with missing libs to fix broken shared build (authored by junaire). · Explain Why
This revision was automatically updated to reflect the committed changes.
junaire added a commit: rG8431436e543f: Link with missing libs to fix broken shared build.
Harbormaster completed remote builds in B200772: Diff 479637.Dec 2 2022, 8:23 AM

Revision Contents

PathSize
clang-tools-extra/
include-cleaner/
lib/
1 line
tool/
1 line

Diff 479644

clang-tools-extra/include-cleaner/lib/CMakeLists.txt

Show All 10 Linesadd_clang_library(clangIncludeCleaner
) )
clang_target_link_libraries(clangIncludeCleaner clang_target_link_libraries(clangIncludeCleaner
PRIVATE PRIVATE
clangAST clangAST
clangBasic clangBasic
clangFormat clangFormat
clangLex clangLex
clangToolingCore
clangToolingInclusions clangToolingInclusions
clangToolingInclusionsStdlib clangToolingInclusionsStdlib
) )

clang-tools-extra/include-cleaner/tool/CMakeLists.txt

set(LLVM_LINK_COMPONENTS Support) set(LLVM_LINK_COMPONENTS Support)
include_directories("../lib") # FIXME: use public APIs instead. include_directories("../lib") # FIXME: use public APIs instead.
add_clang_tool(clang-include-cleaner IncludeCleaner.cpp) add_clang_tool(clang-include-cleaner IncludeCleaner.cpp)
clang_target_link_libraries(clang-include-cleaner PRIVATE clang_target_link_libraries(clang-include-cleaner PRIVATE
clangBasic clangBasic
clangFrontend clangFrontend
clangLex clangLex
clangFormat
clangSerialization clangSerialization
clangTooling clangTooling
) )
target_link_libraries(clang-include-cleaner PRIVATE target_link_libraries(clang-include-cleaner PRIVATE
clangIncludeCleaner clangIncludeCleaner
) )