This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Refactoring: Move teams forking and serial region forking to separate functions.
ClosedPublic

Authored by tlwilmar on Dec 1 2022, 7:31 AM.

Details

Summary

Code for serial parallel regions and teams construct have been moved out of kmp_fork_call and into separate functions. This is to reduce the size of the kmp_fork_call function, and aid in debugging.

Diff Detail

Event Timeline

tlwilmar created this revision.Dec 1 2022, 7:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2022, 7:31 AM
tlwilmar requested review of this revision.Dec 1 2022, 7:31 AM
jlpeyton added inline comments.Dec 12 2022, 6:48 AM
openmp/runtime/src/kmp_runtime.cpp
1357–1360

This should be kmp_va_list instead of the #ifdef.

1371–1374

Same

1392–1396

Same

1627–1632

Same

tlwilmar updated this revision to Diff 482237.Dec 12 2022, 12:55 PM

Thanks Johnny -- made all the fixes you mentioned.

This revision is now accepted and ready to land.Dec 12 2022, 2:11 PM