Querying the storage class in the verifier will assume the result
type is of pointer types. We need to check that's true first to
make sure it won't crash.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Paths
| Differential D139053
[mlir][spirv] Check GlobalVariableOp result to be of pointer types ClosedPublic Authored by antiagainst on Nov 30 2022, 3:35 PM.
Details Summary Querying the storage class in the verifier will assume the result
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Nov 30 2022, 3:56 PM Closed by commit rGb948a9f40ffe: [mlir][spirv] Check GlobalVariableOp result to be of pointer types (authored by antiagainst). · Explain WhyNov 30 2022, 4:13 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 479094 mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
mlir/test/Dialect/SPIRV/IR/structure-ops.mlir
|