This is an archive of the discontinued LLVM Phabricator instance.

Differential D139011

[InstCombine] Precommit D138814 tests
ClosedPublic

Authored by Pierre-vh on Nov 30 2022, 6:19 AM.

Details

Reviewers
spatel
Commits
rG561471b1b84f: [InstCombine] Precommit D138814 tests
Summary

Separate commit for D138814's testcases to make review easier.

Diff Detail

Event Timeline

Pierre-vh created this revision.Nov 30 2022, 6:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 6:19 AM
Pierre-vh requested review of this revision.Nov 30 2022, 6:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 6:19 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Pierre-vh added a child revision: D138814: [InstCombine] Combine lshr of add -> (a + b < a).Nov 30 2022, 6:20 AM
Pierre-vh mentioned this in D138814: [InstCombine] Combine lshr of add -> (a + b < a).Nov 30 2022, 6:21 AM
Harbormaster completed remote builds in B200258: Diff 478928.Nov 30 2022, 7:09 AM
spatel accepted this revision.Nov 30 2022, 10:42 AM

LGTM - no need for pre-commit review to add NFC tests.
Although we may want the discussion to continue before committing to main - in case we're missing more corner cases.

This revision is now accepted and ready to land.Nov 30 2022, 10:42 AM
Pierre-vh updated this revision to Diff 479536.Dec 2 2022, 12:31 AM

Add more testcases

Harbormaster completed remote builds in B200708: Diff 479536.Dec 2 2022, 3:08 AM
Pierre-vh updated this revision to Diff 486813.Jan 6 2023, 4:28 AM

Rebase

Pierre-vh updated this revision to Diff 486822.Jan 6 2023, 5:14 AM

Remove comments in test

Pierre-vh updated this revision to Diff 486829.Jan 6 2023, 5:27 AM

Update to only check zext

Herald added a subscriber: hiraditya. · View Herald TranscriptJan 6 2023, 5:27 AM
Pierre-vh updated this revision to Diff 486835.Jan 6 2023, 5:36 AM

Cleanup accidental squash

Harbormaster completed remote builds in B206091: Diff 486835.Jan 6 2023, 6:35 AM
Pierre-vh updated this revision to Diff 487353.Jan 9 2023, 2:42 AM

Add multi-use tests

Herald added a subscriber: StephenFan. · View Herald TranscriptJan 9 2023, 2:42 AM
Harbormaster completed remote builds in B206482: Diff 487353.Jan 9 2023, 4:42 AM
Closed by commit rG561471b1b84f: [InstCombine] Precommit D138814 tests (authored by Pierre-vh). · Explain WhyJan 10 2023, 12:28 AM
This revision was automatically updated to reflect the committed changes.
Pierre-vh added a commit: rG561471b1b84f: [InstCombine] Precommit D138814 tests.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
279 lines

Diff 486822

llvm/test/Transforms/InstCombine/shift-add.ll

Show First 20 Lines • Show All 425 Lines • ▼ Show 20 Lines
; CHECK-NEXT: [[A:%.*]] = xor i4 [[X:%.*]], -8 ; CHECK-NEXT: [[A:%.*]] = xor i4 [[X:%.*]], -8
; CHECK-NEXT: [[R:%.*]] = shl nsw i4 2, [[A]] ; CHECK-NEXT: [[R:%.*]] = shl nsw i4 2, [[A]]
; CHECK-NEXT: ret i4 [[R]] ; CHECK-NEXT: ret i4 [[R]]
; ;
%a = add i4 %x, 8 %a = add i4 %x, 8
%r = shl nsw i4 2, %a %r = shl nsw i4 2, %a
ret i4 %r ret i4 %r
} }
define i2 @lshr_2_add_zext_basic(i1 %a, i1 %b) {
; CHECK-LABEL: @lshr_2_add_zext_basic(
; CHECK-NEXT: [[TMP1:%.*]] = and i1 [[A:%.*]], [[B:%.*]]
; CHECK-NEXT: [[LSHR:%.*]] = zext i1 [[TMP1]] to i2
; CHECK-NEXT: ret i2 [[LSHR]]
;
%zext.a = zext i1 %a to i2
%zext.b = zext i1 %b to i2
%add = add i2 %zext.a, %zext.b
%lshr = lshr i2 %add, 1
ret i2 %lshr
}
define i2 @ashr_2_add_zext_basic(i1 %a, i1 %b) {
; CHECK-LABEL: @ashr_2_add_zext_basic(
; CHECK-NEXT: [[ZEXT_A:%.*]] = zext i1 [[A:%.*]] to i2
; CHECK-NEXT: [[ZEXT_B:%.*]] = zext i1 [[B:%.*]] to i2
; CHECK-NEXT: [[ADD:%.*]] = add nuw i2 [[ZEXT_A]], [[ZEXT_B]]
; CHECK-NEXT: [[LSHR:%.*]] = ashr i2 [[ADD]], 1
; CHECK-NEXT: ret i2 [[LSHR]]
;
%zext.a = zext i1 %a to i2
%zext.b = zext i1 %b to i2
%add = add i2 %zext.a, %zext.b
%lshr = ashr i2 %add, 1
ret i2 %lshr
}
define i32 @lshr_16_add_zext_basic(i16 %a, i16 %b) {
; CHECK-LABEL: @lshr_16_add_zext_basic(
; CHECK-NEXT: [[ZEXT_A:%.*]] = zext i16 [[A:%.*]] to i32
; CHECK-NEXT: [[ZEXT_B:%.*]] = zext i16 [[B:%.*]] to i32
; CHECK-NEXT: [[ADD:%.*]] = add nuw nsw i32 [[ZEXT_A]], [[ZEXT_B]]
; CHECK-NEXT: [[LSHR:%.*]] = lshr i32 [[ADD]], 16
; CHECK-NEXT: ret i32 [[LSHR]]
;
%zext.a = zext i16 %a to i32
%zext.b = zext i16 %b to i32
%add = add i32 %zext.a, %zext.b
%lshr = lshr i32 %add, 16
ret i32 %lshr
}
define i32 @lshr_16_add_known_16_leading_zeroes(i32 %a, i32 %b) {
; CHECK-LABEL: @lshr_16_add_known_16_leading_zeroes(
; CHECK-NEXT: [[A16:%.*]] = and i32 [[A:%.*]], 65535
; CHECK-NEXT: [[B16:%.*]] = and i32 [[B:%.*]], 65535
; CHECK-NEXT: [[ADD:%.*]] = add nuw nsw i32 [[A16]], [[B16]]
; CHECK-NEXT: [[LSHR:%.*]] = lshr i32 [[ADD]], 16
; CHECK-NEXT: ret i32 [[LSHR]]
;
%a16 = and i32 %a, 65535 ; 0x65535
%b16 = and i32 %b, 65535 ; 0x65535
%add = add i32 %a16, %b16
%lshr = lshr i32 %add, 16
ret i32 %lshr
}
define i32 @lshr_16_add_not_known_16_leading_zeroes(i32 %a, i32 %b) {
; CHECK-LABEL: @lshr_16_add_not_known_16_leading_zeroes(
; CHECK-NEXT: [[A16:%.*]] = and i32 [[A:%.*]], 131071
; CHECK-NEXT: [[B16:%.*]] = and i32 [[B:%.*]], 65535
; CHECK-NEXT: [[ADD:%.*]] = add nuw nsw i32 [[A16]], [[B16]]
; CHECK-NEXT: [[LSHR:%.*]] = lshr i32 [[ADD]], 16
; CHECK-NEXT: ret i32 [[LSHR]]
;
%a16 = and i32 %a, 131071 ; 0x1FFFF
%b16 = and i32 %b, 65535 ; 0x65535
%add = add i32 %a16, %b16
%lshr = lshr i32 %add, 16
ret i32 %lshr
}
define i64 @lshr_32_add_zext_basic(i32 %a, i32 %b) {
; CHECK-LABEL: @lshr_32_add_zext_basic(
; CHECK-NEXT: [[ZEXT_A:%.*]] = zext i32 [[A:%.*]] to i64
; CHECK-NEXT: [[ZEXT_B:%.*]] = zext i32 [[B:%.*]] to i64
; CHECK-NEXT: [[ADD:%.*]] = add nuw nsw i64 [[ZEXT_A]], [[ZEXT_B]]
; CHECK-NEXT: [[LSHR:%.*]] = lshr i64 [[ADD]], 32
; CHECK-NEXT: ret i64 [[LSHR]]
;
%zext.a = zext i32 %a to i64
%zext.b = zext i32 %b to i64
%add = add i64 %zext.a, %zext.b
%lshr = lshr i64 %add, 32
ret i64 %lshr
}
define i64 @lshr_31_i32_add_zext_basic(i32 %a, i32 %b) {
; CHECK-LABEL: @lshr_31_i32_add_zext_basic(
; CHECK-NEXT: [[ZEXT_A:%.*]] = zext i32 [[A:%.*]] to i64
; CHECK-NEXT: [[ZEXT_B:%.*]] = zext i32 [[B:%.*]] to i64
; CHECK-NEXT: [[ADD:%.*]] = add nuw nsw i64 [[ZEXT_A]], [[ZEXT_B]]
; CHECK-NEXT: [[LSHR:%.*]] = lshr i64 [[ADD]], 31
; CHECK-NEXT: ret i64 [[LSHR]]
;
%zext.a = zext i32 %a to i64
%zext.b = zext i32 %b to i64
%add = add i64 %zext.a, %zext.b
%lshr = lshr i64 %add, 31
ret i64 %lshr
}
define i64 @lshr_33_i32_add_zext_basic(i32 %a, i32 %b) {
; CHECK-LABEL: @lshr_33_i32_add_zext_basic(
; CHECK-NEXT: ret i64 0
;
%zext.a = zext i32 %a to i64
%zext.b = zext i32 %b to i64
%add = add i64 %zext.a, %zext.b
%lshr = lshr i64 %add, 33
ret i64 %lshr
}
define i64 @lshr_16_to_64_add_zext_basic(i16 %a, i16 %b) {
; CHECK-LABEL: @lshr_16_to_64_add_zext_basic(
; CHECK-NEXT: [[ZEXT_A:%.*]] = zext i16 [[A:%.*]] to i64
; CHECK-NEXT: [[ZEXT_B:%.*]] = zext i16 [[B:%.*]] to i64
; CHECK-NEXT: [[ADD:%.*]] = add nuw nsw i64 [[ZEXT_A]], [[ZEXT_B]]
; CHECK-NEXT: [[LSHR:%.*]] = lshr i64 [[ADD]], 16
; CHECK-NEXT: ret i64 [[LSHR]]
;
%zext.a = zext i16 %a to i64
%zext.b = zext i16 %b to i64
%add = add i64 %zext.a, %zext.b
%lshr = lshr i64 %add, 16
ret i64 %lshr
}
define i64 @lshr_32_add_known_32_leading_zeroes(i64 %a, i64 %b) {
; CHECK-LABEL: @lshr_32_add_known_32_leading_zeroes(
; CHECK-NEXT: [[A32:%.*]] = and i64 [[A:%.*]], 4294967295
; CHECK-NEXT: [[B32:%.*]] = and i64 [[B:%.*]], 4294967295
; CHECK-NEXT: [[ADD:%.*]] = add nuw nsw i64 [[A32]], [[B32]]
; CHECK-NEXT: [[LSHR:%.*]] = lshr i64 [[ADD]], 32
; CHECK-NEXT: ret i64 [[LSHR]]
;
%a32 = and i64 %a, 4294967295 ; 0xFFFFFFFF
%b32 = and i64 %b, 4294967295 ; 0xFFFFFFFF
%add = add i64 %a32, %b32
%lshr = lshr i64 %add, 32
ret i64 %lshr
}
define i64 @lshr_32_add_not_known_32_leading_zeroes(i64 %a, i64 %b) {
;
; CHECK-LABEL: @lshr_32_add_not_known_32_leading_zeroes(
; CHECK-NEXT: [[A32:%.*]] = and i64 [[A:%.*]], 8589934591
; CHECK-NEXT: [[B32:%.*]] = and i64 [[B:%.*]], 4294967295
; CHECK-NEXT: [[ADD:%.*]] = add nuw nsw i64 [[A32]], [[B32]]
; CHECK-NEXT: [[LSHR:%.*]] = lshr i64 [[ADD]], 32
; CHECK-NEXT: ret i64 [[LSHR]]
;
%a32 = and i64 %a, 8589934591 ; 0x1FFFFFFFF
%b32 = and i64 %b, 4294967295 ; 0xFFFFFFFF
%add = add i64 %a32, %b32
%lshr = lshr i64 %add, 32
ret i64 %lshr
}
define i32 @ashr_16_add_zext_basic(i16 %a, i16 %b) {
; CHECK-LABEL: @ashr_16_add_zext_basic(
; CHECK-NEXT: [[ZEXT_A:%.*]] = zext i16 [[A:%.*]] to i32
; CHECK-NEXT: [[ZEXT_B:%.*]] = zext i16 [[B:%.*]] to i32
; CHECK-NEXT: [[ADD:%.*]] = add nuw nsw i32 [[ZEXT_A]], [[ZEXT_B]]
; CHECK-NEXT: [[LSHR:%.*]] = lshr i32 [[ADD]], 16
; CHECK-NEXT: ret i32 [[LSHR]]
;
%zext.a = zext i16 %a to i32
%zext.b = zext i16 %b to i32
%add = add i32 %zext.a, %zext.b
%lshr = lshr i32 %add, 16
ret i32 %lshr
}
define i64 @ashr_32_add_zext_basic(i32 %a, i32 %b) {
; CHECK-LABEL: @ashr_32_add_zext_basic(
; CHECK-NEXT: [[ZEXT_A:%.*]] = zext i32 [[A:%.*]] to i64
; CHECK-NEXT: [[ZEXT_B:%.*]] = zext i32 [[B:%.*]] to i64
; CHECK-NEXT: [[ADD:%.*]] = add nuw nsw i64 [[ZEXT_A]], [[ZEXT_B]]
; CHECK-NEXT: [[LSHR:%.*]] = lshr i64 [[ADD]], 32
; CHECK-NEXT: ret i64 [[LSHR]]
;
%zext.a = zext i32 %a to i64
%zext.b = zext i32 %b to i64
%add = add i64 %zext.a, %zext.b
%lshr = ashr i64 %add, 32
ret i64 %lshr
}
define i64 @ashr_16_to_64_add_zext_basic(i16 %a, i16 %b) {
; CHECK-LABEL: @ashr_16_to_64_add_zext_basic(
; CHECK-NEXT: [[ZEXT_A:%.*]] = zext i16 [[A:%.*]] to i64
; CHECK-NEXT: [[ZEXT_B:%.*]] = zext i16 [[B:%.*]] to i64
; CHECK-NEXT: [[ADD:%.*]] = add nuw nsw i64 [[ZEXT_A]], [[ZEXT_B]]
; CHECK-NEXT: [[LSHR:%.*]] = lshr i64 [[ADD]], 16
; CHECK-NEXT: ret i64 [[LSHR]]
;
%zext.a = zext i16 %a to i64
%zext.b = zext i16 %b to i64
%add = add i64 %zext.a, %zext.b
%lshr = ashr i64 %add, 16
ret i64 %lshr
}
define i32 @lshr_32_add_zext_trunc(i32 %a, i32 %b) {
; CHECK-LABEL: @lshr_32_add_zext_trunc(
; CHECK-NEXT: [[ZEXT_A:%.*]] = zext i32 [[A:%.*]] to i64
; CHECK-NEXT: [[ZEXT_B:%.*]] = zext i32 [[B:%.*]] to i64
; CHECK-NEXT: [[ADD:%.*]] = add nuw nsw i64 [[ZEXT_A]], [[ZEXT_B]]
; CHECK-NEXT: [[TRUNC_ADD:%.*]] = trunc i64 [[ADD]] to i32
; CHECK-NEXT: [[SHR:%.*]] = lshr i64 [[ADD]], 32
; CHECK-NEXT: [[TRUNC_SHR:%.*]] = trunc i64 [[SHR]] to i32
; CHECK-NEXT: [[RET:%.*]] = add i32 [[TRUNC_ADD]], [[TRUNC_SHR]]
; CHECK-NEXT: ret i32 [[RET]]
;
%zext.a = zext i32 %a to i64
%zext.b = zext i32 %b to i64
%add = add i64 %zext.a, %zext.b
%trunc.add = trunc i64 %add to i32
%shr = lshr i64 %add, 32
%trunc.shr = trunc i64 %shr to i32
%ret = add i32 %trunc.add, %trunc.shr
ret i32 %ret
}
define <3 x i32> @add3_i96(<3 x i32> %0, <3 x i32> %1) {
; CHECK-LABEL: @add3_i96(
; CHECK-NEXT: [[TMP3:%.*]] = extractelement <3 x i32> [[TMP0:%.*]], i64 0
; CHECK-NEXT: [[TMP4:%.*]] = zext i32 [[TMP3]] to i64
; CHECK-NEXT: [[TMP5:%.*]] = extractelement <3 x i32> [[TMP1:%.*]], i64 0
; CHECK-NEXT: [[TMP6:%.*]] = zext i32 [[TMP5]] to i64
; CHECK-NEXT: [[TMP7:%.*]] = add nuw nsw i64 [[TMP6]], [[TMP4]]
; CHECK-NEXT: [[TMP8:%.*]] = extractelement <3 x i32> [[TMP0]], i64 1
; CHECK-NEXT: [[TMP9:%.*]] = zext i32 [[TMP8]] to i64
; CHECK-NEXT: [[TMP10:%.*]] = extractelement <3 x i32> [[TMP1]], i64 1
; CHECK-NEXT: [[TMP11:%.*]] = zext i32 [[TMP10]] to i64
; CHECK-NEXT: [[TMP12:%.*]] = add nuw nsw i64 [[TMP11]], [[TMP9]]
; CHECK-NEXT: [[TMP13:%.*]] = lshr i64 [[TMP7]], 32
; CHECK-NEXT: [[TMP14:%.*]] = add nuw nsw i64 [[TMP12]], [[TMP13]]
; CHECK-NEXT: [[TMP15:%.*]] = extractelement <3 x i32> [[TMP0]], i64 2
; CHECK-NEXT: [[TMP16:%.*]] = extractelement <3 x i32> [[TMP1]], i64 2
; CHECK-NEXT: [[TMP17:%.*]] = add i32 [[TMP16]], [[TMP15]]
; CHECK-NEXT: [[TMP18:%.*]] = lshr i64 [[TMP14]], 32
; CHECK-NEXT: [[TMP19:%.*]] = trunc i64 [[TMP18]] to i32
; CHECK-NEXT: [[TMP20:%.*]] = add i32 [[TMP17]], [[TMP19]]
; CHECK-NEXT: [[TMP21:%.*]] = trunc i64 [[TMP7]] to i32
; CHECK-NEXT: [[TMP22:%.*]] = insertelement <3 x i32> undef, i32 [[TMP21]], i64 0
; CHECK-NEXT: [[TMP23:%.*]] = trunc i64 [[TMP14]] to i32
; CHECK-NEXT: [[TMP24:%.*]] = insertelement <3 x i32> [[TMP22]], i32 [[TMP23]], i64 1
; CHECK-NEXT: [[TMP25:%.*]] = insertelement <3 x i32> [[TMP24]], i32 [[TMP20]], i64 2
; CHECK-NEXT: ret <3 x i32> [[TMP25]]
;
%3 = extractelement <3 x i32> %0, i64 0
%4 = zext i32 %3 to i64
%5 = extractelement <3 x i32> %1, i64 0
%6 = zext i32 %5 to i64
%7 = add nuw nsw i64 %6, %4
%8 = extractelement <3 x i32> %0, i64 1
%9 = zext i32 %8 to i64
%10 = extractelement <3 x i32> %1, i64 1
%11 = zext i32 %10 to i64
%12 = add nuw nsw i64 %11, %9
%13 = lshr i64 %7, 32
%14 = add nuw nsw i64 %12, %13
%15 = extractelement <3 x i32> %0, i64 2
%16 = extractelement <3 x i32> %1, i64 2
%17 = add i32 %16, %15
%18 = lshr i64 %14, 32
%19 = trunc i64 %18 to i32
%20 = add i32 %17, %19
%21 = trunc i64 %7 to i32
%22 = insertelement <3 x i32> undef, i32 %21, i32 0
%23 = trunc i64 %14 to i32
%24 = insertelement <3 x i32> %22, i32 %23, i32 1
%25 = insertelement <3 x i32> %24, i32 %20, i32 2
ret <3 x i32> %25
}