This is an archive of the discontinued LLVM Phabricator instance.

Differential D139001

Do not include <alloca.h> unconditionally
ClosedPublic

Authored by arichardson on Nov 30 2022, 4:10 AM.

Details

Reviewers
ro
fhahn
Commits
rT372064913a99: Do not include <alloca.h> unconditionally
Summary

Some systems (e.g. FreeBSD) do not provide this header. This commit fixes
building the testsuite on FreeBSD after c4c6c75c1ff888f47a203e5aeadc85b1d2aaa172

Diff Detail

Event Timeline

arichardson created this revision.Nov 30 2022, 4:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 4:10 AM
Herald added subscribers: krytarowski, emaste. · View Herald Transcript
arichardson requested review of this revision.Nov 30 2022, 4:10 AM
Harbormaster completed remote builds in B200232: Diff 478888.Nov 30 2022, 4:10 AM
arichardson mentioned this in D133579: Fix Solaris compilation.Nov 30 2022, 4:11 AM
ro accepted this revision.Dec 7 2022, 6:31 AM

For good measure tested on sparcv9-sun-solaris2.11, amd64-pc-solaris2.11, and x86_64-pc-linux-gnu.

LGTM.

Sorry for the breakage.

This revision is now accepted and ready to land.Dec 7 2022, 6:31 AM
Closed by commit rT372064913a99: Do not include <alloca.h> unconditionally (authored by arichardson). · Explain WhyDec 7 2022, 7:00 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rT372064913a99: Do not include <alloca.h> unconditionally.

Revision Contents

PathSize
MultiSource/
Applications/
oggenc/
2 lines
Benchmarks/
MiBench/
consumer-lame/
2 lines

Diff 478888

MultiSource/Applications/oggenc/oggenc.c

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
/* OggEnc /* OggEnc
* *
* This program is distributed under the GNU General Public License, version 2. * This program is distributed under the GNU General Public License, version 2.
* A copy of this license is included with this source. * A copy of this license is included with this source.
* *
* Copyright 2000-2002, Michael Smith <msmith@xiph.org> * Copyright 2000-2002, Michael Smith <msmith@xiph.org>
* *
* Portions from Vorbize, (c) Kenneth Arnold <kcarnold@yahoo.com> * Portions from Vorbize, (c) Kenneth Arnold <kcarnold@yahoo.com>
* and libvorbis examples, (c) Monty <monty@xiph.org> * and libvorbis examples, (c) Monty <monty@xiph.org>
*/ */
#if __has_include(<alloca.h>)
#include <alloca.h> #include <alloca.h>
#endif
#include <assert.h> #include <assert.h>
#include <ctype.h> #include <ctype.h>
#include <errno.h> #include <errno.h>
#include <fcntl.h> #include <fcntl.h>
#include <locale.h> #include <locale.h>
#include <math.h> #include <math.h>
#include <stdarg.h> #include <stdarg.h>
#include <stdio.h> #include <stdio.h>
▲ Show 20 Lines • Show All 32,759 Lines • Show Last 20 Lines

MultiSource/Benchmarks/MiBench/consumer-lame/rtp.c

#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <netinet/in.h> #include <netinet/in.h>
#include <unistd.h> #include <unistd.h>
#include <stdlib.h> #include <stdlib.h>
#include <stdio.h> #include <stdio.h>
#if __has_include(<alloca.h>)
#include <alloca.h> #include <alloca.h>
#endif
#include <sys/types.h> #include <sys/types.h>
#include <sys/socket.h> #include <sys/socket.h>
#include <arpa/inet.h> #include <arpa/inet.h>
struct rtpbits { struct rtpbits {
int sequence:16; /* sequence number: random */ int sequence:16; /* sequence number: random */
int pt:7; /* payload type: 14 for MPEG audio */ int pt:7; /* payload type: 14 for MPEG audio */
int m:1; /* marker: 0 */ int m:1; /* marker: 0 */
▲ Show 20 Lines • Show All 88 Lines • Show Last 20 Lines