This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Add test sanity test if amdgcn.device.{init|fini} already exist
ClosedPublic

Authored by arsenm on Nov 29 2022, 7:27 AM.

Details

Reviewers
sameerds
reshabh
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

arsenm created this revision.Nov 29 2022, 7:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 7:27 AM
arsenm requested review of this revision.Nov 29 2022, 7:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 7:27 AM
Herald added a subscriber: wdng. · View Herald Transcript

Redundant word "test" in the first line of the commit description?

Also, how is "something sane" defined? What is the semantics for ctors and dtors that are linked in after init and fini have already been created?

arsenm added a comment.Dec 9 2022, 5:02 AM

Redundant word "test" in the first line of the commit description?

Also, how is "something sane" defined? What is the semantics for ctors and dtors that are linked in after init and fini have already been created?

I was thinking "not crash". The actual functionality is driven off the attribute, so it seems like multiple are supposed to work

sameerds accepted this revision.Dec 9 2022, 7:33 AM

LGTM, with the two nits fixed.

llvm/test/CodeGen/AMDGPU/lower-ctor-dtor-existing.ll
4

Rephrase to "do not crash or error out if ..."

This revision is now accepted and ready to land.Dec 9 2022, 7:33 AM