Diff Detail
Diff Detail
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Redundant word "test" in the first line of the commit description?
Also, how is "something sane" defined? What is the semantics for ctors and dtors that are linked in after init and fini have already been created?
Comment Actions
I was thinking "not crash". The actual functionality is driven off the attribute, so it seems like multiple are supposed to work
Comment Actions
LGTM, with the two nits fixed.
llvm/test/CodeGen/AMDGPU/lower-ctor-dtor-existing.ll | ||
---|---|---|
4 | Rephrase to "do not crash or error out if ..." |
Rephrase to "do not crash or error out if ..."