This is an archive of the discontinued LLVM Phabricator instance.

Differential D138907

[flang] Remove warnings that fast-math options are unimplemented
ClosedPublic

Authored by tblah on Nov 29 2022, 3:40 AM.

Details

Reviewers
vzakhari
kiranchandramohan
awarzynski
Commits
rG6841c43f36ee: [flang] Remove warnings that fast-math options are unimplemented
Summary

These are now fully implemented, see

These flags are still tested in flang/test/Driver/frontend-forwarding.f90 and flang/test/Lower/fast-math-arithmetic.f90.

Diff Detail

Event Timeline

tblah created this revision.Nov 29 2022, 3:40 AM
Herald added a reviewer: awarzynski. · View Herald TranscriptNov 29 2022, 3:40 AM
Herald added a project: Restricted Project. · View Herald Transcript
tblah requested review of this revision.Nov 29 2022, 3:40 AM
tblah mentioned this in D138675: [flang] Add -ffast-math and -Ofast.Nov 29 2022, 3:48 AM
Harbormaster completed remote builds in B199972: Diff 478506.Nov 29 2022, 3:57 AM
awarzynski added a comment.Nov 29 2022, 6:13 AM

Makes sense, LGTM! Please wait for @vzakhari to take a look as well.

vzakhari accepted this revision.Nov 29 2022, 9:00 AM

Thank you!

This revision is now accepted and ready to land.Nov 29 2022, 9:00 AM
Closed by commit rG6841c43f36ee: [flang] Remove warnings that fast-math options are unimplemented (authored by tblah). · Explain WhyNov 29 2022, 9:17 AM
This revision was automatically updated to reflect the committed changes.
tblah added a commit: rG6841c43f36ee: [flang] Remove warnings that fast-math options are unimplemented.
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 9:17 AM
vzakhari added a comment.EditedNov 29 2022, 5:47 PM

There are build warnings about unused variables around if (const llvm::opt::Arg *a = now.
Can you please clean it up?

Herald added a subscriber: jdoerfert. · View Herald TranscriptNov 29 2022, 5:47 PM
vzakhari added a comment.Nov 29 2022, 5:49 PM

There are build warnings about unused variables around if (const llvm::opt::Arg *a = now.
Can you please clean it up?

clementval added a subscriber: clementval.Nov 30 2022, 1:06 AM

As @vzakhari this is triggering 6 new warnings for unused variable 'a'. Can you please fix it?

clementval added a comment.Nov 30 2022, 1:08 AM

This is also breaking this buildbot: https://lab.llvm.org/buildbot/#/builders/160

tblah added a comment.Nov 30 2022, 2:38 AM

Sorry about this, it should be fixed by https://github.com/llvm/llvm-project/commit/3a1b40925486c1eea80e2a0e636b208435487daf

Revision Contents

PathSize
flang/
lib/
Frontend/
9 lines
test/
Driver/

Diff 478625

flang/lib/Frontend/CompilerInvocation.cpp

Show First 20 Lines • Show All 671 Lines • ▼ Show 20 Lines
/// ///
/// \param [out] invoc Stores the processed arguments /// \param [out] invoc Stores the processed arguments
/// \param [in] args The compiler invocation arguments to parse /// \param [in] args The compiler invocation arguments to parse
/// \param [out] diags DiagnosticsEngine to report erros with /// \param [out] diags DiagnosticsEngine to report erros with
static bool parseFloatingPointArgs(CompilerInvocation &invoc, static bool parseFloatingPointArgs(CompilerInvocation &invoc,
llvm::opt::ArgList &args, llvm::opt::ArgList &args,
clang::DiagnosticsEngine &diags) { clang::DiagnosticsEngine &diags) {
LangOptions &opts = invoc.getLangOpts(); LangOptions &opts = invoc.getLangOpts();
const unsigned diagUnimplemented = diags.getCustomDiagID(
clang::DiagnosticsEngine::Warning, "%0 is not currently implemented");
if (const llvm::opt::Arg *a = if (const llvm::opt::Arg *a =
args.getLastArg(clang::driver::options::OPT_ffp_contract)) { args.getLastArg(clang::driver::options::OPT_ffp_contract)) {
const llvm::StringRef val = a->getValue(); const llvm::StringRef val = a->getValue();
enum LangOptions::FPModeKind fpContractMode; enum LangOptions::FPModeKind fpContractMode;
if (val == "off") if (val == "off")
fpContractMode = LangOptions::FPM_Off; fpContractMode = LangOptions::FPM_Off;
else if (val == "fast") else if (val == "fast")
fpContractMode = LangOptions::FPM_Fast; fpContractMode = LangOptions::FPM_Fast;
else { else {
diags.Report(clang::diag::err_drv_unsupported_option_argument) diags.Report(clang::diag::err_drv_unsupported_option_argument)
<< a->getSpelling() << val; << a->getSpelling() << val;
return false; return false;
} }
diags.Report(diagUnimplemented) << a->getOption().getName();
opts.setFPContractMode(fpContractMode); opts.setFPContractMode(fpContractMode);
} }
if (const llvm::opt::Arg *a = if (const llvm::opt::Arg *a =
args.getLastArg(clang::driver::options::OPT_menable_no_infinities)) { args.getLastArg(clang::driver::options::OPT_menable_no_infinities)) {
diags.Report(diagUnimplemented) << a->getOption().getName();
opts.NoHonorInfs = true; opts.NoHonorInfs = true;
} }
if (const llvm::opt::Arg *a = if (const llvm::opt::Arg *a =
args.getLastArg(clang::driver::options::OPT_menable_no_nans)) { args.getLastArg(clang::driver::options::OPT_menable_no_nans)) {
diags.Report(diagUnimplemented) << a->getOption().getName();
opts.NoHonorNaNs = true; opts.NoHonorNaNs = true;
} }
if (const llvm::opt::Arg *a = if (const llvm::opt::Arg *a =
args.getLastArg(clang::driver::options::OPT_fapprox_func)) { args.getLastArg(clang::driver::options::OPT_fapprox_func)) {
diags.Report(diagUnimplemented) << a->getOption().getName();
opts.ApproxFunc = true; opts.ApproxFunc = true;
} }
if (const llvm::opt::Arg *a = if (const llvm::opt::Arg *a =
args.getLastArg(clang::driver::options::OPT_fno_signed_zeros)) { args.getLastArg(clang::driver::options::OPT_fno_signed_zeros)) {
diags.Report(diagUnimplemented) << a->getOption().getName();
opts.NoSignedZeros = true; opts.NoSignedZeros = true;
} }
if (const llvm::opt::Arg *a = if (const llvm::opt::Arg *a =
args.getLastArg(clang::driver::options::OPT_mreassociate)) { args.getLastArg(clang::driver::options::OPT_mreassociate)) {
diags.Report(diagUnimplemented) << a->getOption().getName();
opts.AssociativeMath = true; opts.AssociativeMath = true;
} }
if (const llvm::opt::Arg *a = if (const llvm::opt::Arg *a =
args.getLastArg(clang::driver::options::OPT_freciprocal_math)) { args.getLastArg(clang::driver::options::OPT_freciprocal_math)) {
diags.Report(diagUnimplemented) << a->getOption().getName();
opts.ReciprocalMath = true; opts.ReciprocalMath = true;
} }
return true; return true;
} }
bool CompilerInvocation::createFromArgs( bool CompilerInvocation::createFromArgs(
CompilerInvocation &res, llvm::ArrayRef<const char *> commandLineArgs, CompilerInvocation &res, llvm::ArrayRef<const char *> commandLineArgs,
▲ Show 20 Lines • Show All 227 Lines • Show Last 20 Lines

flang/test/Driver/flang_fp_opts.f90

  • This file was deleted.
! Test for handling of floating point options within the frontend driver
! RUN: %flang_fc1 \
! RUN: -ffp-contract=fast \
! RUN: -menable-no-infs \
! RUN: -menable-no-nans \
! RUN: -fapprox-func \
! RUN: -fno-signed-zeros \
! RUN: -mreassociate \
! RUN: -freciprocal-math \
! RUN: %s 2>&1 | FileCheck %s
! CHECK: ffp-contract= is not currently implemented
! CHECK: menable-no-infs is not currently implemented
! CHECK: menable-no-nans is not currently implemented
! CHECK: fapprox-func is not currently implemented
! CHECK: fno-signed-zeros is not currently implemented
! CHECK: mreassociate is not currently implemented
! CHECK: freciprocal-math is not currently implemented
flang/lib/Frontend/CompilerInvocation.cpp