This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC][NFC] Add test case for memset tail store
ClosedPublic

Authored by tingwang on Nov 28 2022, 5:01 PM.

Details

Summary

Add test case to show something can be improved.

Diff Detail

Event Timeline

tingwang created this revision.Nov 28 2022, 5:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 5:01 PM
tingwang requested review of this revision.Nov 28 2022, 5:01 PM

I think that for completeness, we should add tests where the size is less than a full vector's width (i.e. 1, 4, 5, 8, 9, 12, 15 bytes).

tingwang updated this revision to Diff 478533.Nov 29 2022, 5:02 AM

Add more test cases according to comment.

tingwang updated this revision to Diff 479539.Dec 2 2022, 12:43 AM

Add memset2TailV1Bx() cases which does not fit in vspltisb and may require constant pool.

shchenz accepted this revision as: shchenz.Dec 7 2022, 12:37 AM

LGTM. Go ahead to commit these cases first. If there are more missing tests found during the review of D138883, we can add them by then

This revision is now accepted and ready to land.Dec 7 2022, 12:37 AM
This revision was landed with ongoing or failed builds.Dec 12 2022, 5:07 PM
This revision was automatically updated to reflect the committed changes.