Page MenuHomePhabricator

[mlir][transform] Add PackedOrDynamicIndexList helper
ClosedPublic

Authored by springerm on Nov 28 2022, 8:35 AM.

Details

Summary

This custom parser/printer is similar to DynamicIndexList, but has special syntax for the case where one handle represents the entire list.

Example:

// Regular index list
[10, 20, %val]

// Packed handle (no square parentheses)
%val

Diff Detail

Event Timeline

springerm created this revision.Nov 28 2022, 8:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 8:35 AM
springerm requested review of this revision.Nov 28 2022, 8:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 8:35 AM
ftynse accepted this revision.Dec 15 2022, 8:32 AM
ftynse added inline comments.
mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp
1580

Nit: why is integer capitalized in the message?

This revision is now accepted and ready to land.Dec 15 2022, 8:32 AM
nicolasvasilache accepted this revision.Dec 15 2022, 8:37 AM
This revision was automatically updated to reflect the committed changes.