This is an archive of the discontinued LLVM Phabricator instance.

[asan][test] Fix SED issues with macOS (BSD)
ClosedPublic

Authored by rsundahl on Nov 28 2022, 8:32 AM.

Details

Summary

SED differs between GNU and BSD in handling semicolon and the use of
'\n' in regex patterns. For macOS we can't use these GNU extensions.

rdar://102686948

Diff Detail

Event Timeline

rsundahl created this revision.Nov 28 2022, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 8:32 AM
Herald added a subscriber: Enna1. · View Herald Transcript
rsundahl requested review of this revision.Nov 28 2022, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 8:32 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yln accepted this revision.Nov 28 2022, 10:14 AM
yln added a reviewer: zequanwu.

LGTM & thanks from my side!

Previous switch from grep to sed to make Windows bot work by @vitalybuka here: a27089101edf
@vitalybuka, can you confirm this still works for Windows and the other environments you care about?

This revision is now accepted and ready to land.Nov 28 2022, 10:14 AM

FWIW: I tested this sed syntax on latest Alpine, CentOS, Debian and Ubuntu and all ok.

thetruestblue accepted this revision.Nov 28 2022, 3:57 PM

Thanks for fixing this quick, @rsundahl.

thakis added a subscriber: thakis.Nov 29 2022, 9:17 AM

Building on macOS has been broken for close to a week now. Is this blocked on anything? If so, can we revert the original change for now, to unbreak the build?

This revision was landed with ongoing or failed builds.Nov 29 2022, 9:50 AM
This revision was automatically updated to reflect the committed changes.