Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM. But tt's better be checked by @gonglingqin who wrote most of the AMO pseudos.
llvm/unittests/Target/LoongArch/InstSizes.cpp | ||
---|---|---|
118–130 | This is less readable. Could you write each instruction in one line. If clang-format fail, clang-format off/on may help. |
llvm/unittests/Target/LoongArch/CMakeLists.txt | ||
---|---|---|
11 | Do you need all these dependencies? From a quick look, InstSizes.cpp seems to not include files from most of these. |
Comment Actions
The test added in this change fails:
[ RUN ] InstSizes.AtomicPseudo # Machine code for function sizes: IsSSA, NoPHIs, NoVRegs Jump Tables: %jump-table.0: %bb.0 bb.0: dead early-clobber renamable $r10, dead early-clobber renamable $r11 = PseudoMaskedAtomicLoadAdd32 renamable $r7, renamable $r6, renamable $r8, 4 dead early-clobber renamable $r10, dead early-clobber renamable $r11 = PseudoAtomicLoadAdd32 renamable $r7, renamable $r6 dead early-clobber renamable $r5, dead early-clobber renamable $r9, dead early-clobber renamable $r10 = PseudoMaskedAtomicLoadUMax32 renamable $r7, renamable $r6, renamable $r8, 4 early-clobber renamable $r9, dead early-clobber renamable $r10, dead early-clobber renamable $r11 = PseudoMaskedAtomicLoadMax32 killed renamable $r6, killed renamable $r5, killed renamable $r7, killed renamable $r8, 4 dead early-clobber renamable $r5, dead early-clobber renamable $r9 = PseudoCmpXchg32 renamable $r7, renamable $r4, renamable $r6 dead early-clobber renamable $r5, dead early-clobber renamable $r9 = PseudoMaskedCmpXchg32 killed renamable $r7, killed renamable $r4, killed renamable $r6, killed renamable $r8, 4 # End machine code for function sizes. *** Bad machine code: Too few operands *** - function: sizes - basic block: %bb.0 (0x14181e4c8) - instruction: dead early-clobber renamable $r10, dead early-clobber renamable $r11 = PseudoAtomicLoadAdd32 renamable $r7, renamable $r6 5 operands expected, but 4 given. LLVM ERROR: Found 1 machine code errors.
Please take a look and revert for now if it takes a while to fix.
llvm/unittests/Target/LoongArch/CMakeLists.txt | ||
---|---|---|
11 | Thanks, I delete the redundant dependencies. |
Do you need all these dependencies? From a quick look, InstSizes.cpp seems to not include files from most of these.