This is an archive of the discontinued LLVM Phabricator instance.

Differential D138445

[libcxx] Add BOT_OWNERS.txt
ClosedPublic

Authored by DavidSpickett on Nov 21 2022, 9:11 AM.

Details

Reviewers
EricWF
ldionne
Group Reviewers
Restricted Project
Commits
rG75e09ce9b3bf: [libcxx] Add BOT_OWNERS.txt
Summary

Buildkite doesn't provide a way to list bot owners so currently
we are pinging people on Discord and Phabricator.

Which works ok until that person is on vacation. This file gives us
a place to list multiple people, or group contacts for each bot.

I've stuck to the CODE_OWNERS.txt format because there's no great
reason to change it.

Diff Detail

Unit TestsFailed

TimeTest
10,670 mslibcxx CI AIX (32-bit) > ibm-libc++-shared-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_cons::path.pass.cpp
9,900 mslibcxx CI AIX (32-bit) > ibm-libc++-shared-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_mods::assign.pass.cpp
10,720 mslibcxx CI AIX (32-bit) > ibm-libc++-shared-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_mods::refresh.pass.cpp
10,320 mslibcxx CI AIX (32-bit) > ibm-libc++-shared-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_mods::replace_filename.pass.cpp
10,650 mslibcxx CI AIX (32-bit) > ibm-libc++-shared-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_obs::file_size.pass.cpp
View Full Test Results (27 Failed)

Event Timeline

DavidSpickett created this revision.Nov 21 2022, 9:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 9:11 AM
Herald added a subscriber: arichardson. · View Herald Transcript
DavidSpickett requested review of this revision.Nov 21 2022, 9:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 9:11 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
DavidSpickett added a comment.Nov 21 2022, 9:16 AM

Though being able to add discord/phab names would be nice and sod's law that the format took D and P already. We can figure something out if that would be useful.

EricWF accepted this revision.Nov 21 2022, 9:35 AM
This revision is now accepted and ready to land.Nov 21 2022, 9:35 AM
Harbormaster completed remote builds in B198808: Diff 476925.Nov 21 2022, 9:43 PM
ldionne accepted this revision.Nov 22 2022, 6:57 AM
ldionne added subscribers: daltenty, ldionne.

@daltenty Heads up to add the AIX information to this file.

Thanks @DavidSpickett !

DavidSpickett added a comment.Nov 22 2022, 7:36 AM

I will land this then, others can add to it.

Also, I saw another CODE_OWNERS using "H" for Phabricator Handle so that is an option.

DavidSpickett updated this revision to Diff 477194.Nov 22 2022, 7:41 AM

Note H for Phabricator handle.

This revision was landed with ongoing or failed builds.Nov 22 2022, 7:41 AM
Closed by commit rG75e09ce9b3bf: [libcxx] Add BOT_OWNERS.txt (authored by DavidSpickett). · Explain Why
This revision was automatically updated to reflect the committed changes.
DavidSpickett added a commit: rG75e09ce9b3bf: [libcxx] Add BOT_OWNERS.txt.
Harbormaster completed remote builds in B198984: Diff 477194.Nov 22 2022, 11:41 AM
daltenty mentioned this in D138580: [libc++][AIX] Add AIX buildbot owners.Nov 23 2022, 8:20 AM
daltenty mentioned this in rG194ab73a419c: [libc++][AIX] Add AIX buildbot owners.Nov 24 2022, 8:46 AM

Revision Contents

PathSize
libcxx/
docs/
3 lines
utils/
ci/
13 lines

Diff 477194

libcxx/docs/AddingNewCIJobs.rst

Show All 40 Lines
config appropriately. config appropriately.
We try to keep the pipeline definition file as simple as possible, and to We try to keep the pipeline definition file as simple as possible, and to
keep any script used for CI inside ``libcxx/utils/ci``. This ensures that keep any script used for CI inside ``libcxx/utils/ci``. This ensures that
it's possible to reproduce CI issues locally with ease, understanding of it's possible to reproduce CI issues locally with ease, understanding of
course that some setups may require access to special hardware that is not course that some setups may require access to special hardware that is not
available. available.
Finally, add your contact info to ``libcxx/utils/ci/BOT_OWNERS.txt``. This will
be used to contact you when there are issues with the bot.
Testing Your New Job Testing Your New Job
==================== ====================
Testing your new job is easy -- once your agent is set up (if any), just open Testing your new job is easy -- once your agent is set up (if any), just open
a code review and the libc++ CI pipeline will run, including any changes you a code review and the libc++ CI pipeline will run, including any changes you
might have made to the pipeline definition itself. might have made to the pipeline definition itself.
Service Level Agreement Service Level Agreement
Show All 10 Lines

libcxx/utils/ci/BOT_OWNERS.txt

  • This file was added.
This file is a list of the people or groups responsible for ensuring that bots
are running correctly. They will also deal with platform specific issues that
cannot be figured out by the community alone.
The list is sorted by surname and formatted to allow easy grepping and
beautification by scripts. The fields are: name (N), email (E), web-address
(W), PGP key ID and fingerprint (P), description (D), snail-mail address
(S), Phabricator handle (H) and IRC handle (I). Each entry should contain at
least the (N), (E) and (D) fields.
N: Linaro Toolchain Working Group
E: linaro-toolchain@lists.linaro.org
D: Armv7, Armv8, AArch64