This is an archive of the discontinued LLVM Phabricator instance.

Differential D138305

[bolt] Make test/X86/end-symbol.test not use "tac"
ClosedPublic

Authored by thakis on Nov 18 2022, 8:34 AM.

Details

Reviewers
maksfb
rafauler
Amir
Commits
rG59b9673b4570: [bolt] Make test/X86/end-symbol.test not use "tac"
Summary

"tac" doesn't exist on macOS, so this makes the test pass there.

Diff Detail

Event Timeline

thakis created this revision.Nov 18 2022, 8:34 AM
Herald added a reviewer: rafauler. · View Herald TranscriptNov 18 2022, 8:34 AM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: treapster, ayermolo. · View Herald Transcript
thakis requested review of this revision.Nov 18 2022, 8:34 AM
Herald added a subscriber: yota9. · View Herald TranscriptNov 18 2022, 8:34 AM
Harbormaster completed remote builds in B198485: Diff 476494.Nov 18 2022, 8:52 AM
rafauler accepted this revision.Nov 18 2022, 9:04 AM

LGTM

This revision is now accepted and ready to land.Nov 18 2022, 9:04 AM
Closed by commit rG59b9673b4570: [bolt] Make test/X86/end-symbol.test not use "tac" (authored by thakis). · Explain WhyNov 18 2022, 9:08 AM
This revision was automatically updated to reflect the committed changes.
thakis added a commit: rG59b9673b4570: [bolt] Make test/X86/end-symbol.test not use "tac".
Herald added a project: Restricted Project. · View Herald TranscriptNov 18 2022, 9:09 AM

Revision Contents

PathSize
bolt/
test/
X86/
2 lines

Diff 476507

bolt/test/X86/end-symbol.test

# RUN: yaml2obj %p/Inputs/plt-sec.yaml &> %t.exe # RUN: yaml2obj %p/Inputs/plt-sec.yaml &> %t.exe
# RUN: llvm-bolt %t.exe -o %t.out # RUN: llvm-bolt %t.exe -o %t.out
# RUN: (llvm-readelf --program-headers %t.out | tac ; llvm-nm %t.out) \ # RUN: (llvm-readelf --program-headers %t.out | grep LOAD | tail -n 1 ; llvm-nm %t.out) \
# RUN: | FileCheck %s # RUN: | FileCheck %s
## Check that llvm-bolt correctly updates _end symbol to match the end of the ## Check that llvm-bolt correctly updates _end symbol to match the end of the
## last loadable segment. ## last loadable segment.
CHECK: LOAD 0x[[#%x,OFFSET:]] 0x[[#%x,VMA:]] 0x[[#%x,PA:]] 0x[[#%x,FILESIZE:]] 0x[[#%x,MEMSIZE:]] CHECK: LOAD 0x[[#%x,OFFSET:]] 0x[[#%x,VMA:]] 0x[[#%x,PA:]] 0x[[#%x,FILESIZE:]] 0x[[#%x,MEMSIZE:]]
CHECK: [[#%.16x, VMA + MEMSIZE]] {{.}} _end CHECK: [[#%.16x, VMA + MEMSIZE]] {{.}} _end