This is an archive of the discontinued LLVM Phabricator instance.

[COFF] Improve JIT support of weak symbols
ClosedPublic

Authored by v.g.vassilev on Nov 17 2022, 11:19 PM.

Details

Summary

Teach RuntimeDyld to handle COFF weak references and to consider comdat symbols as weak.

Patch by Lang Hames and Sunho Kim!

I struggle creating a test case but this patch fixes a large amount of test failures for Cling and ROOT (https://github.com/root-project/root/pull/10294) when moving llvm13 and orcv2. Can somebody help me how to test this?

Diff Detail

Event Timeline

v.g.vassilev created this revision.Nov 17 2022, 11:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 17 2022, 11:19 PM
v.g.vassilev requested review of this revision.Nov 17 2022, 11:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 17 2022, 11:19 PM

Added a testcase by Sunho!

lhames accepted this revision.Jan 24 2023, 9:00 AM

LGTM!

This revision is now accepted and ready to land.Jan 24 2023, 9:00 AM
This revision was landed with ongoing or failed builds.Jan 24 2023, 10:26 AM
This revision was automatically updated to reflect the committed changes.