This is an archive of the discontinued LLVM Phabricator instance.

Differential D137987

[mlir][sparse] Fix warning on GCC
ClosedPublic

Authored by wrengr on Nov 14 2022, 2:44 PM.

Details

Reviewers
aartbik
bixia
Peiming
Commits
rG9aaf509d7ebe: [mlir][sparse] Fix warning on GCC

Diff Detail

Event Timeline

wrengr created this revision.Nov 14 2022, 2:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 14 2022, 2:44 PM
Herald added subscribers: Moerafaat, bzcheeseman, sdasgup3 and 17 others. · View Herald Transcript
wrengr requested review of this revision.Nov 14 2022, 2:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 14 2022, 2:44 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Peiming accepted this revision.Nov 14 2022, 2:44 PM
This revision is now accepted and ready to land.Nov 14 2022, 2:44 PM
aartbik accepted this revision.Nov 14 2022, 2:44 PM
Harbormaster completed remote builds in B197628: Diff 475281.Nov 14 2022, 3:00 PM
This revision was landed with ongoing or failed builds.Nov 14 2022, 3:01 PM
Closed by commit rG9aaf509d7ebe: [mlir][sparse] Fix warning on GCC (authored by wrengr). · Explain Why
This revision was automatically updated to reflect the committed changes.
wrengr added a commit: rG9aaf509d7ebe: [mlir][sparse] Fix warning on GCC.

Revision Contents

PathSize
mlir/
include/
mlir/
ExecutionEngine/
SparseTensor/
1 line

Diff 475289

mlir/include/mlir/ExecutionEngine/SparseTensor/PermutationRef.h

Show First 20 Lines • Show All 121 Lines • ▼ Show 20 Lines inline std::vector<T> permute(uint64_t size, const T *values) const {
return out; return out;
} }
template <typename T> template <typename T>
inline void permute(uint64_t size, const T *values, T *out) const { inline void permute(uint64_t size, const T *values, T *out) const {
assert(size == permSize && "size mismatch"); assert(size == permSize && "size mismatch");
for (uint64_t i = 0; i < permSize; ++i) for (uint64_t i = 0; i < permSize; ++i)
out[i] = values[perm[i]]; out[i] = values[perm[i]];
return out;
} }
private: private:
const uint64_t permSize; const uint64_t permSize;
const uint64_t *const perm; // non-owning pointer. const uint64_t *const perm; // non-owning pointer.
}; };
} // namespace detail } // namespace detail
} // namespace sparse_tensor } // namespace sparse_tensor
} // namespace mlir } // namespace mlir
#endif // MLIR_EXECUTIONENGINE_SPARSETENSOR_PERMUTATIONREF_H #endif // MLIR_EXECUTIONENGINE_SPARSETENSOR_PERMUTATIONREF_H