Hyphens were missing from the triple, causing it to be parsed
incorrectly. This patch updates the triple and makes necessary
changes to the expected output.
Patch is from Vinicius Tinti.
Paths
| Differential D13792
Fix incorrect target triple in fp16-promote.ll ClosedPublic Authored by pirama on Oct 15 2015, 4:47 PM.
Details Summary Hyphens were missing from the triple, causing it to be parsed Patch is from Vinicius Tinti.
Diff Detail Event Timelinepirama updated this object. Comment Actions Hi, This is weird, and I'd like to know more why the extra dash makes that big a difference... cheers, This revision now requires changes to proceed.Oct 16 2015, 6:28 AM Comment Actions
It is because the "environment" is not parsed in the original case. This is the environment parser:
Comment Actions Frontends emit LLVM IR with --- (three dashes) to avoid ambiguous interpretation. Example: ; ModuleID = 'main.c' target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64" target triple = "armv7---eabihf" Abiguous triples are only accepted in -target in Clang for compatibility reasons. rengolin edited edge metadata. Comment Actions
Indeed! LGTM. Thanks! This revision is now accepted and ready to land.Oct 20 2015, 1:44 PM Closed by commit rL251020: Fix incorrect target triple in fp16-promote.ll (authored by pirama). · Explain WhyOct 22 2015, 7:17 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 37538 test/CodeGen/ARM/fp16-promote.ll
|