Page MenuHomePhabricator

tinti (Vinicius Tinti)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2013, 3:01 PM (415 w, 2 d)

Recent Activity

Mar 24 2021

tinti committed rG804ff7f2933f: [llvm-objdump] Implement --prefix-strip option (authored by tinti).
[llvm-objdump] Implement --prefix-strip option
Mar 24 2021, 6:27 AM
tinti closed D96679: [llvm-objdump] Implement --prefix-strip option.
Mar 24 2021, 6:27 AM · Restricted Project

Mar 6 2021

tinti added a comment to D96679: [llvm-objdump] Implement --prefix-strip option.

Sorry for the delay. I've been off sick for much of the week, and am still catching up on things.

Mar 6 2021, 2:28 AM · Restricted Project
tinti updated the diff for D96679: [llvm-objdump] Implement --prefix-strip option.

Add invalid text test.

Mar 6 2021, 2:27 AM · Restricted Project

Mar 4 2021

tinti added a comment to D96679: [llvm-objdump] Implement --prefix-strip option.

@jhenderson ping?

Mar 4 2021, 8:36 AM · Restricted Project

Feb 26 2021

tinti updated the diff for D96679: [llvm-objdump] Implement --prefix-strip option.

Reword documentation.
Use good result test instead of bad result.
Add invalid value test.
Convert C code to C++.

Feb 26 2021, 3:53 AM · Restricted Project

Feb 18 2021

tinti updated the diff for D96679: [llvm-objdump] Implement --prefix-strip option.

Add range tests.
Add extra separator test.
Add assert.
Use uint32_t instead of int.
Comment about not using Path.h iterator.

Feb 18 2021, 5:04 PM · Restricted Project
tinti added inline comments to D96679: [llvm-objdump] Implement --prefix-strip option.
Feb 18 2021, 6:57 AM · Restricted Project

Feb 14 2021

tinti updated the diff for D96679: [llvm-objdump] Implement --prefix-strip option.

Fix patch does not apply.

Feb 14 2021, 6:46 PM · Restricted Project
tinti requested review of D96679: [llvm-objdump] Implement --prefix-strip option.
Feb 14 2021, 6:39 PM · Restricted Project

Feb 9 2021

tinti committed rG8b4a72728101: [llvm-objdump][test] Fix --prefix tests for system-windows (authored by tinti).
[llvm-objdump][test] Fix --prefix tests for system-windows
Feb 9 2021, 1:58 PM
tinti closed D95513: [llvm-objdump][test] Fix --prefix tests for system-windows.
Feb 9 2021, 1:58 PM · Restricted Project

Feb 1 2021

tinti added a comment to D95513: [llvm-objdump][test] Fix --prefix tests for system-windows.

Forgot to click "Accept Revision". @tinti, have you asked for commit access?

Feb 1 2021, 5:34 AM · Restricted Project

Jan 29 2021

tinti added a comment to D95513: [llvm-objdump][test] Fix --prefix tests for system-windows.

Can you commit?

Jan 29 2021, 7:08 AM · Restricted Project

Jan 27 2021

tinti updated the diff for D95513: [llvm-objdump][test] Fix --prefix tests for system-windows.

Reword as suggested.

Jan 27 2021, 5:44 AM · Restricted Project
tinti updated the diff for D95513: [llvm-objdump][test] Fix --prefix tests for system-windows.

Reword.
Explain behavior for adding {{[/\\]}}
Fix missing EOFs.

Jan 27 2021, 5:14 AM · Restricted Project
tinti added inline comments to D95513: [llvm-objdump][test] Fix --prefix tests for system-windows.
Jan 27 2021, 4:12 AM · Restricted Project
tinti added a comment to D95513: [llvm-objdump][test] Fix --prefix tests for system-windows.

Tested on Windows and Linux.

Jan 27 2021, 2:14 AM · Restricted Project
tinti updated the summary of D95513: [llvm-objdump][test] Fix --prefix tests for system-windows.
Jan 27 2021, 2:14 AM · Restricted Project
tinti requested review of D95513: [llvm-objdump][test] Fix --prefix tests for system-windows.
Jan 27 2021, 2:14 AM · Restricted Project

Oct 16 2020

tinti added a comment to D85024: [llvm-objdump] Implement --prefix option.

Thanks @MaskRay and @thakis.

Oct 16 2020, 1:53 PM · Restricted Project

Oct 13 2020

tinti added a comment to D85024: [llvm-objdump] Implement --prefix option.

@MaskRay ping?

Oct 13 2020, 2:51 PM · Restricted Project

Oct 9 2020

tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.

Concise use of = in tests.
Merge ifs.
Reorder alphabetically the options.

Oct 9 2020, 2:45 AM · Restricted Project

Oct 8 2020

tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.

Reword.
Use James suggestions.

Oct 8 2020, 6:35 AM · Restricted Project
tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.

Reword comments.
Substitute CHECK-TRAILING.
Remove extra sed pipe.
Add test for relative paths.

Oct 8 2020, 5:43 AM · Restricted Project
tinti added inline comments to D85024: [llvm-objdump] Implement --prefix option.
Oct 8 2020, 5:36 AM · Restricted Project

Oct 7 2020

tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.

Add specific tests.
Reword.

Oct 7 2020, 4:29 PM · Restricted Project
tinti added a comment to D88502: [llvm][Support] Delete unused is_absolute_gnu helper.

Hi @tinti this code seems to be recently introduced without any usage, and as pointed out by @certl it doesn't consider multi-byte drive letters.

Oct 7 2020, 4:26 PM · Restricted Project

Oct 5 2020

tinti added a comment to D85024: [llvm-objdump] Implement --prefix option.

I believe I should create more tests addressing:

Oct 5 2020, 7:49 PM · Restricted Project

Sep 24 2020

tinti added a comment to D87667: [Support/Path] Add path::is_absolute_gnu.

This patch added an issue in some builds:

Sep 24 2020, 3:40 AM · Restricted Project

Sep 23 2020

tinti added inline comments to D87667: [Support/Path] Add path::is_absolute_gnu.
Sep 23 2020, 4:26 AM · Restricted Project
tinti updated the summary of D87667: [Support/Path] Add path::is_absolute_gnu.
Sep 23 2020, 4:25 AM · Restricted Project
tinti updated the diff for D87667: [Support/Path] Add path::is_absolute_gnu.

Add reference to cppreference.com.
Improve comments.

Sep 23 2020, 4:25 AM · Restricted Project

Sep 21 2020

tinti updated the diff for D87667: [Support/Path] Add path::is_absolute_gnu.

Remove SmallVector.
Move comment to is_absolute.
Reword documentation.
Add references.

Sep 21 2020, 1:39 PM · Restricted Project
tinti added a comment to D87667: [Support/Path] Add path::is_absolute_gnu.

I have done several rewords.

Sep 21 2020, 1:31 PM · Restricted Project
tinti updated the diff for D87667: [Support/Path] Add path::is_absolute_gnu.
  • Drop the "_style" in the name of the function.
  • Add ":" test.
  • Add comment about LLVM is_absolute.
  • Add Vector constructor.
Sep 21 2020, 4:14 AM · Restricted Project

Sep 18 2020

tinti updated the diff for D87667: [Support/Path] Add path::is_absolute_gnu.

Add more tests;
Simplify is_gnu_style_absolute;
Reword comments;
Reword commit message.

Sep 18 2020, 3:24 AM · Restricted Project

Sep 16 2020

tinti added inline comments to D87667: [Support/Path] Add path::is_absolute_gnu.
Sep 16 2020, 2:30 AM · Restricted Project

Sep 15 2020

tinti added a comment to D87667: [Support/Path] Add path::is_absolute_gnu.

On Windows, paths starting with drive letter pattern are absolute.

This isn't a difference is it? That's also the behaviour for is_absolute, I believe?

Sep 15 2020, 7:14 PM · Restricted Project
tinti added a comment to D87667: [Support/Path] Add path::is_absolute_gnu.
Sep 15 2020, 6:52 PM · Restricted Project

Sep 14 2020

tinti requested review of D87667: [Support/Path] Add path::is_absolute_gnu.
Sep 14 2020, 7:25 PM · Restricted Project

Sep 1 2020

tinti added a comment to D85024: [llvm-objdump] Implement --prefix option.

Should these crash tests take into account the Style?

Sep 1 2020, 5:25 PM · Restricted Project

Aug 26 2020

tinti added a comment to D85024: [llvm-objdump] Implement --prefix option.

Having given it some thought, I think the right thing to do might be to put a method alongside the existing is_absolute method called something like either is_rooted, or is_gnu_style_absolute or similar. That function would then look something like this:

bool is_rooted(StringRef Path, Style St) {
  if (is_absolute(Path, St))
    return true;
  if (real_style(St) == windows)
    return !Path.empty() && is_separator(Path.front(), St);
  return false;
}

I would probably recommend that that be added in a separate patch, with dedicated gtest unit tests and reviewers taken from among those who have recently worked in this area (plus myself). You would then rebase this patch on top of that one.

Aug 26 2020, 4:31 PM · Restricted Project

Aug 25 2020

tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.

Work done so far.

Aug 25 2020, 7:36 PM · Restricted Project
tinti updated subscribers of D85024: [llvm-objdump] Implement --prefix option.
Aug 25 2020, 7:34 PM · Restricted Project
tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.

Just adding my work so far.

Aug 25 2020, 9:16 AM · Restricted Project
tinti added inline comments to D85024: [llvm-objdump] Implement --prefix option.
Aug 25 2020, 9:13 AM · Restricted Project

Aug 24 2020

tinti added inline comments to D85024: [llvm-objdump] Implement --prefix option.
Aug 24 2020, 5:57 PM · Restricted Project
tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.

Use ;; for comments.
Remove double blanks.
Remove unsupported for Windows [1].
Add helper function of objdump::is_absolute().
Remove duplicated checks.
Rename TRAILING check.

Aug 24 2020, 5:56 PM · Restricted Project
tinti added inline comments to D85024: [llvm-objdump] Implement --prefix option.
Aug 24 2020, 2:22 PM · Restricted Project

Aug 16 2020

tinti added inline comments to D85024: [llvm-objdump] Implement --prefix option.
Aug 16 2020, 3:16 PM · Restricted Project
tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.

Fix documentation.

Aug 16 2020, 3:11 PM · Restricted Project

Aug 11 2020

tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.

Reword llvm/docs/CommandGuide/llvm-objdump.rst
Keep Windows as unsupported. [1]
Use -D in FileCheck for better testing.
Put primary test on top of the file. The primary use is to fix a wrong or incomplete path.
Fix missing --check-prefix on trailing test.
Remove comments about compatibility with GNU's objdump.
Remove namespace llvm:: where it is not needed.
Remove braces.
Add test comments.
Remove test checks that can be removed. [2]

Aug 11 2020, 7:32 PM · Restricted Project

Aug 10 2020

tinti added a comment to D85024: [llvm-objdump] Implement --prefix option.
Aug 10 2020, 4:47 AM · Restricted Project

Aug 6 2020

tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.

Add documentation.
Remove Windows test.
Implement remove trailing separators on prefix.
Add a real usage test case (wrong prefix fixed by --prefix).

Aug 6 2020, 7:13 PM · Restricted Project

Aug 4 2020

tinti added a comment to D85024: [llvm-objdump] Implement --prefix option.

Hi @tinti - please remember to upload with full diff context. I previously pointed you at the page on how to do so. Not including full context makes things harder to review.

Aug 4 2020, 6:32 PM · Restricted Project
tinti added inline comments to D85024: [llvm-objdump] Implement --prefix option.
Aug 4 2020, 4:02 AM · Restricted Project
tinti added inline comments to D85024: [llvm-objdump] Implement --prefix option.
Aug 4 2020, 3:56 AM · Restricted Project

Aug 3 2020

tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.
  • Add documentation.
  • Add a FIXME on Windows.
  • Fix a forced absolute paths bug on Unix-lie.
Aug 3 2020, 6:28 PM · Restricted Project
tinti added a comment to D85024: [llvm-objdump] Implement --prefix option.

Please remember to update the documentation located at llvm/docs/CommandGuide for llvm-objdump, to include the new option.

Aug 3 2020, 6:27 PM · Restricted Project

Aug 1 2020

tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.

Make old test unsupported for Windows.
Add new test for Windows.
Reword --prefix help text.

Aug 1 2020, 12:27 PM · Restricted Project

Jul 31 2020

tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.

Expected to fix failed test case on Windows.

Jul 31 2020, 6:55 PM · Restricted Project
tinti added inline comments to D85024: [llvm-objdump] Implement --prefix option.
Jul 31 2020, 5:33 PM · Restricted Project
tinti added inline comments to D85024: [llvm-objdump] Implement --prefix option.
Jul 31 2020, 9:02 AM · Restricted Project
tinti requested review of D85024: [llvm-objdump] Implement --prefix option.
Jul 31 2020, 5:27 AM · Restricted Project

Feb 11 2016

tinti awarded D16851: Update of "GCC extensions not implemented yet" in Clang User's Manual a Like token.
Feb 11 2016, 3:28 AM

Nov 20 2015

tinti closed D14804: [clang] Disable Unicode in asm files.

r253738

Nov 20 2015, 3:59 PM
tinti committed rL253738: [clang] Disable Unicode in asm files.
[clang] Disable Unicode in asm files
Nov 20 2015, 3:45 PM
tinti committed rL253737: Test commit.
Test commit
Nov 20 2015, 3:22 PM

Nov 18 2015

tinti set the repository for D14804: [clang] Disable Unicode in asm files to rL LLVM.
Nov 18 2015, 6:41 PM
tinti updated the diff for D14804: [clang] Disable Unicode in asm files.
Nov 18 2015, 6:41 PM
tinti added a reviewer for D14804: [clang] Disable Unicode in asm files: mehdi_amini.
Nov 18 2015, 6:39 PM
tinti retitled D14804: [clang] Disable Unicode in asm files from to [clang] Disable Unicode in asm files.
Nov 18 2015, 6:38 PM

Nov 6 2015

tinti added inline comments to D14184: [clang] Add initial support for -meabi flag.
Nov 6 2015, 2:55 PM
tinti updated D12413: [llvm] Add initial support for -meabi flag.
Nov 6 2015, 2:46 PM
tinti updated the diff for D12413: [llvm] Add initial support for -meabi flag.
Nov 6 2015, 2:45 PM
tinti updated the diff for D14184: [clang] Add initial support for -meabi flag.
  • Add test for error check
  • Change StringSwitch to use lllvm::EABI type
Nov 6 2015, 2:42 PM
tinti updated the diff for D14184: [clang] Add initial support for -meabi flag.
Nov 6 2015, 12:59 PM

Nov 5 2015

tinti added a comment to D12413: [llvm] Add initial support for -meabi flag.

Hi Vinicius,

This now looks good to me. Thanks!

You may have to change your clang patch, too, due to the change in -meabi here.

Nov 5 2015, 12:42 PM
tinti retitled D12413: [llvm] Add initial support for -meabi flag from [llvm] Add initial support for -eabi flag to [llvm] Add initial support for -meabi flag.
Nov 5 2015, 12:38 PM
tinti added a comment to D12413: [llvm] Add initial support for -meabi flag.
Nov 5 2015, 12:26 PM
tinti added a comment to D12413: [llvm] Add initial support for -meabi flag.
Nov 5 2015, 12:23 PM
tinti updated the diff for D12413: [llvm] Add initial support for -meabi flag.
  • Change flag to "meabi" to be keep consistence with Clang.
  • Use full call for memops functions to not be missinterpreted from memops functions.
  • Remove extra CHECK.
Nov 5 2015, 12:23 PM

Nov 4 2015

tinti added inline comments to D14184: [clang] Add initial support for -meabi flag.
Nov 4 2015, 6:27 PM
tinti updated the diff for D14184: [clang] Add initial support for -meabi flag.

Clang format.

Nov 4 2015, 6:24 PM
tinti added a comment to D12413: [llvm] Add initial support for -meabi flag.
Nov 4 2015, 6:23 PM
tinti added a comment to D12413: [llvm] Add initial support for -meabi flag.
Nov 4 2015, 6:23 PM
tinti updated the diff for D12413: [llvm] Add initial support for -meabi flag.
  • Use enum class.
  • Clang format (except in two places for readability).
Nov 4 2015, 6:21 PM
tinti added inline comments to D12413: [llvm] Add initial support for -meabi flag.
Nov 4 2015, 2:19 PM

Nov 3 2015

tinti added inline comments to D12413: [llvm] Add initial support for -meabi flag.
Nov 3 2015, 1:33 PM
tinti updated the diff for D14184: [clang] Add initial support for -meabi flag.
  • Clang format code.
  • Update eabi names to match new LLVM patch.
Nov 3 2015, 1:08 PM

Oct 30 2015

tinti added inline comments to D14184: [clang] Add initial support for -meabi flag.
Oct 30 2015, 10:33 AM
tinti added inline comments to D14184: [clang] Add initial support for -meabi flag.
Oct 30 2015, 10:24 AM
tinti updated the diff for D14184: [clang] Add initial support for -meabi flag.

Add context

Oct 30 2015, 6:31 AM
tinti updated the diff for D12413: [llvm] Add initial support for -meabi flag.

Add context

Oct 30 2015, 6:31 AM

Oct 29 2015

tinti updated subscribers of D14184: [clang] Add initial support for -meabi flag.
Oct 29 2015, 2:10 PM
tinti retitled D12413: [llvm] Add initial support for -meabi flag from [ARM] Add -arm-eabi for controlling RTLIB to [llvm] Add initial support for -eabi flag.
Oct 29 2015, 12:46 PM
tinti updated subscribers of D14184: [clang] Add initial support for -meabi flag.
Oct 29 2015, 12:44 PM
tinti retitled D14184: [clang] Add initial support for -meabi flag from to [clang] Add initial support for -meabi flag.
Oct 29 2015, 12:43 PM

Oct 27 2015

tinti added inline comments to D12413: [llvm] Add initial support for -meabi flag.
Oct 27 2015, 11:12 AM